Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes from country to region #1156

Merged
merged 7 commits into from
Nov 10, 2023
Merged

Changes from country to region #1156

merged 7 commits into from
Nov 10, 2023

Conversation

Rouxles
Copy link
Contributor

@Rouxles Rouxles commented Sep 13, 2023

No description provided.

@Rouxles Rouxles requested a review from a team as a code owner September 13, 2023 08:08
@ohexter
Copy link
Contributor

ohexter commented Sep 13, 2023

In many of these cases 'region of representation' may be clearer than 'region', which, careful reading of 2e aside, is likely to be interpreted as where a competitor lives or competes. 2e1 also requires updating.

wca-states.md Show resolved Hide resolved
@Nanush7 Nanush7 changed the title changes from country to region Changes from country to region Sep 29, 2023
@ohexter
Copy link
Contributor

ohexter commented Oct 4, 2023

I'm not sure @thewca/wrt owns this - if it was originally created by James was it WFC related?

Results - are there any database or other places we need to update for region vs. country and the recent changes?

@SAuroux
Copy link
Member

SAuroux commented Oct 4, 2023

I am not sure if I understand the full extent of this change correctly. What codes would need to be updated in the database, is there maybe a concrete example?

In any case @thewca/wrt could support here, but so could @thewca/software-team .

@FinnIckler
Copy link
Member

Code was already changed in thewca/worldcubeassociation.org#8166

@CarterKoala
Copy link
Contributor

In many of these cases 'region of representation' may be clearer than 'region', which, careful reading of 2e aside, is likely to be interpreted as where a competitor lives or competes. 2e1 also requires updating.

I think we should be careful about using terms that are not referenced anywhere else. That said I don't have any better suggestions. Maybe it is still fine to use "region of representation" since it is just a clarifier of region?

@Nanush7
Copy link
Member

Nanush7 commented Oct 4, 2023

Sorry, I should have been more specific. I wanted to ask if any country code requires changes. For example:

Line 184 in wca-states.md: (TW:_Asia) Taiwan.

@OJCubing
Copy link
Contributor

The name of the file should be changed to "WCA List of Recognized Regions" rather than "WCA List of Recognized Regions of Representation". In particular, the regions are also used for the countryid of the competition (and I don't think we would say the competition is representing for that region).

wca-regulations.md Outdated Show resolved Hide resolved
wca-states.md Outdated Show resolved Hide resolved
wca-states.md Outdated Show resolved Hide resolved
Copy link
Member

@Nevseros Nevseros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Nevseros Nevseros merged commit e03bf26 into draft Nov 10, 2023
@Nevseros Nevseros deleted the 2e branch November 10, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants