-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from country to region #1156
Conversation
In many of these cases 'region of representation' may be clearer than 'region', which, careful reading of 2e aside, is likely to be interpreted as where a competitor lives or competes. 2e1 also requires updating. |
I'm not sure @thewca/wrt owns this - if it was originally created by James was it WFC related? Results - are there any database or other places we need to update for region vs. country and the recent changes? |
I am not sure if I understand the full extent of this change correctly. What codes would need to be updated in the database, is there maybe a concrete example? In any case @thewca/wrt could support here, but so could @thewca/software-team . |
Code was already changed in thewca/worldcubeassociation.org#8166 |
I think we should be careful about using terms that are not referenced anywhere else. That said I don't have any better suggestions. Maybe it is still fine to use "region of representation" since it is just a clarifier of region? |
Sorry, I should have been more specific. I wanted to ask if any country code requires changes. For example: Line 184 in wca-states.md: |
The name of the file should be changed to "WCA List of Recognized Regions" rather than "WCA List of Recognized Regions of Representation". In particular, the regions are also used for the countryid of the competition (and I don't think we would say the competition is representing for that region). |
Co-authored-by: Ekaterina Kaneva <[email protected]>
Co-authored-by: Ekaterina Kaneva <[email protected]>
Co-authored-by: Ekaterina Kaneva <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.