zephyr: alloc: virtual_heap_free: Panic on deallocations errors #9779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add k_panic() function call in error handling code to help detect potential memory release errors. The vmh_free function returns an error if: 1. heap belongs to another core, 2. given pointer to be freed is invalid (doesn't belong to the allocator), 3. there is an error in the code determining the size of the block to be freed 4. memory unmapping fails. Log entry is easy to miss, stopping the firmware at this point will draw attention to a critical problem related to memory allocation. Otherwise, it will have a slowly progressing memory leak. Signed-off-by: Adrian Warecki <[email protected]>
softwarecki
requested review from
lyakh,
lgirdwood,
ArsenEloglian,
abonislawski,
kv2019i,
marcinszkudlinski,
jxstelter,
piotrkmx,
kfrydryx,
pjdobrowolski,
tmleman,
serhiy-katsyuba-intel and
gbernatxintel
serhiy-katsyuba-intel
approved these changes
Jan 16, 2025
lgirdwood
reviewed
Jan 16, 2025
| tr_err(&zephyr_tr, "Unable to free %p! %d", ptr, ret); | ||
| k_panic(); |
There was a problem hiding this comment.
Do we really want to panic ? e.g. would a user space module be able to panic with a bad free() ? (and stop all other pipelines)
There was a problem hiding this comment.
Do we really want to panic ? e.g. would a user space module be able to panic with a bad free() ? (and stop all other pipelines)
+1 - maybe we should add some notification to the host about similar important but not fatal errors
tmleman
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add k_panic() function call in error handling code to help detect potential memory release errors.
The vmh_free function returns an error if:
Log entry is easy to miss, stopping the firmware at this point will draw attention to a critical problem related to memory allocation. Otherwise, it will have a slowly progressing memory leak.
If we decide this is a desirable change, we can merge it after #9776 and #9777 have been merged.