sof-logger: exit with error if malloc fails #6847
Conversation
tools/logger/logger.c
Outdated
| @@ -223,6 +223,11 @@ static void *wait_open(const char *watched_dir, const char *expected_file) | |||
|
|
|||
| char * const fpath = malloc(strlen(watched_dir) + 1 + strlen(expected_file) + 1); | |||
|
|
|||
| if (!fpath) { | |||
| fprintf(stdderr, "error: can't allocate memory\n"); | |||
There was a problem hiding this comment.
Typo: stderr. Approve when this is fixed.
There was a problem hiding this comment.
Oops indeed, V2 uploaded. I had compile tested locally, or so I thought. Now went and retested all the four sof-logger PRs I pushed today.
In user-space tools, memory allocations can reasonably be expected to always succeed. Make this assumption explicit by adding error handling after malloc. Signed-off-by: Kai Vehmanen <[email protected]>
kv2019i
force-pushed
the
202212-soflogger-malloc-fail
branch
from
c32b5f4
to
43cd115
Compare
| @@ -223,6 +223,11 @@ static void *wait_open(const char *watched_dir, const char *expected_file) | |||
|
|
|||
| char * const fpath = malloc(strlen(watched_dir) + 1 + strlen(expected_file) + 1); | |||
|
|
|||
| if (!fpath) { | |||
| fprintf(stderr, "error: can't allocate memory\n"); | |||
There was a problem hiding this comment.
A more specific error message would not hurt but it's never going to get printed anyway so who cares
|
The See also |
| @@ -223,6 +223,11 @@ static void *wait_open(const char *watched_dir, const char *expected_file) | |||
|
|
|||
| char * const fpath = malloc(strlen(watched_dir) + 1 + strlen(expected_file) + 1); | |||
|
|
|||
| if (!fpath) { | |||
| fprintf(stderr, "error: can't allocate memory\n"); | |||
| exit(EXIT_FAILURE); | |||
There was a problem hiding this comment.
| exit(EXIT_FAILURE); | |
| abort(); |
I think this tends to print more information.
|
Prefer |
|
The CI failure is unrelated (to a tools change). Proceeding with merge. |
In user-space tools, memory allocations can reasonably be expected to always succeed. Make this assumption explicit by adding error handling after malloc.
Signed-off-by: Kai Vehmanen [email protected]