Add new local_config.bash files to solve device-specific issues #1234
Conversation
No functional change. - Get rid of the "if $ignore_str" condition because it's not going to be empty anytime soon. It will be a very good problem to have when it is! Then it will be easy to turn it into an array like in the next commit. - Don't check whether the $err string is empty but use the `grep` exit status directly. Signed-off-by: Marc Herbert <[email protected]>
Source additional files /etc/sof/local_config.bash and sof-test/case-lib/local_config.bash. This helps solving device-specific issues like thesofproject#1233 and many others before that - for instance git blame the "ignore_str" variable in sof-kernel-log-check.sh Signed-off-by: Marc Herbert <[email protected]>
Leverage the new local_config.bash files to implement device-specific excludes. Signed-off-by: Marc Herbert <[email protected]>
marc-hb
changed the title
|
Expected failures. |
| # - can be arbitrarily complex. Best avoided but only on specific systems anyway. | ||
| # shellcheck disable=SC2154 | ||
| if &>/dev/null declare -p sof_local_extra_kernel_ignores; then | ||
| dlogw "Ignoring extra errors on this particular system:" |
There was a problem hiding this comment.
One concern I have with this facility is that when adding local exceptions becomes easier, it can be used too much and people reading the test logs might not realize some DUTs have local exceptions others don't have. The global ignore list has drawbacks, but at least one needs to make a git commit with proper description and leave something that can be search through git history. OTOH, this dlogw does make local exception use clear in the log, which alleviates my concern. It really depends on how this will be used.
There was a problem hiding this comment.
Thanks for the review!
This is a risk but historically, the abuse has been the other way around: the global list has been abused to add issues with "personal" devices. Just look at the git blame, log and past PRs. I expect the existence of this new feature to be missed and the existing abuse to continue :-) Also, it may seem quick to edit files on one device but what 5 or 6?
Both situations exist, I really think the code should have offered both possibilities a long time ago...
Source additional files /etc/sof/local_config.bash and
sof-test/case-lib/local_config.bash.
This helps solving device-specific issues like #1233 and many others
before that - for instance git blame the "ignore_str" variable in
sof-kernel-log-check.sh