-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hijack.sh: fail on stable-v2.2 FW errors too #1188
Conversation
Let's see if we can start paying attention to firmware errors in the stable-v2.2 branch too. Signed-off-by: Marc Herbert <[email protected]>
Looks like the only error left in stable-v2.2 https://sof-ci.01.org/softestpr/PR1188/build387/devicetest/index.html is |
Lower the log level of `tr_err(&hdma_tr, "hda_dma_link_check_xrun(): underrun detected");` to `tr_warn()`. Underruns are expected when testing pause/start and these errors can hide other, "real", not expected errors; more details in thesofproject/sof-test#1188 This "fixes" 2019 commit 293dfe2 ("hda-dma: refactor xrun handling") Note this driver is not in the main branch anymore, removed by commit 59028ad ("drivers: Intel: remove Intel XTOS drivers") Signed-off-by: Marc Herbert <[email protected]>
Lower the log level of `tr_err(&hdma_tr, "hda_dma_link_check_xrun(): underrun detected");` to `tr_warn()`. Underruns are expected when testing pause/start and these errors can hide other, "real", not expected errors; more details in thesofproject/sof-test#1188 This "fixes" 2019 commit 293dfe2 ("hda-dma: refactor xrun handling") Note this driver is not in the main branch anymore, removed by commit 59028ad ("drivers: Intel: remove Intel XTOS drivers") Signed-off-by: Marc Herbert <[email protected]>
SOFCI TEST https://sof-ci.01.org/softestpr/PR1188/build435/devicetest/index.html was still testing older stable-v2.2 commit 7b46ae6a8a9e, weird... |
SOFCI TEST |
stable-v2.2 https://sof-ci.01.org/softestpr/PR1188/build437/devicetest/index.html is green! Except GLK BOB missing. |
SOFCI TEST |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You never forgot TODOs.
stable-v2.2 test is done, GLK device is not available again, but good to go.
Let's see if we can start paying attention to firmware errors in the stable-v2.2 branch too.
Follow-up to #1075