Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hijack.sh: fail on stable-v2.2 FW errors too #1188

Merged
merged 1 commit into from
May 15, 2024

Conversation

marc-hb
Copy link
Collaborator

@marc-hb marc-hb commented May 2, 2024

Let's see if we can start paying attention to firmware errors in the stable-v2.2 branch too.

Follow-up to #1075

Let's see if we can start paying attention to firmware errors in the
stable-v2.2 branch too.

Signed-off-by: Marc Herbert <[email protected]>
@marc-hb
Copy link
Collaborator Author

marc-hb commented May 2, 2024

Looks like the only error left in stable-v2.2 https://sof-ci.01.org/softestpr/PR1188/build387/devicetest/index.html is ..../intel/hda/hda-dma.c:948 ERROR hda_dma_link_check_xrun(): underrun detected in pause resume tests. Can we downgrade this to a warning?

@plbossart
Copy link
Member

probably a question for @kv2019i and @ujfalusi, I am not sure what the firmware does for pause-push/pause-release...

@marc-hb marc-hb mentioned this pull request May 3, 2024
marc-hb added a commit to marc-hb/sof that referenced this pull request May 9, 2024
Lower the log level of `tr_err(&hdma_tr, "hda_dma_link_check_xrun():
underrun detected");` to `tr_warn()`.

Underruns are expected when testing pause/start and these errors can
hide other, "real", not expected errors; more details in
thesofproject/sof-test#1188

This "fixes" 2019 commit 293dfe2 ("hda-dma: refactor xrun
handling")

Note this driver is not in the main branch anymore, removed by commit
59028ad ("drivers: Intel: remove Intel XTOS drivers")

Signed-off-by: Marc Herbert <[email protected]>
marc-hb added a commit to thesofproject/sof that referenced this pull request May 14, 2024
Lower the log level of `tr_err(&hdma_tr, "hda_dma_link_check_xrun():
underrun detected");` to `tr_warn()`.

Underruns are expected when testing pause/start and these errors can
hide other, "real", not expected errors; more details in
thesofproject/sof-test#1188

This "fixes" 2019 commit 293dfe2 ("hda-dma: refactor xrun
handling")

Note this driver is not in the main branch anymore, removed by commit
59028ad ("drivers: Intel: remove Intel XTOS drivers")

Signed-off-by: Marc Herbert <[email protected]>
@marc-hb
Copy link
Collaborator Author

marc-hb commented May 15, 2024

SOFCI TEST

https://sof-ci.01.org/softestpr/PR1188/build435/devicetest/index.html was still testing older stable-v2.2 commit 7b46ae6a8a9e, weird...

@marc-hb
Copy link
Collaborator Author

marc-hb commented May 15, 2024

SOFCI TEST

@marc-hb
Copy link
Collaborator Author

marc-hb commented May 15, 2024

stable-v2.2 https://sof-ci.01.org/softestpr/PR1188/build437/devicetest/index.html is green! Except GLK BOB missing.

@marc-hb marc-hb marked this pull request as ready for review May 15, 2024 18:05
@marc-hb marc-hb requested a review from a team as a code owner May 15, 2024 18:05
@marc-hb
Copy link
Collaborator Author

marc-hb commented May 15, 2024

SOFCI TEST

Copy link
Collaborator

@fredoh9 fredoh9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You never forgot TODOs.
stable-v2.2 test is done, GLK device is not available again, but good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants