Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib.sh: need sudo bash -c ... to expand fw_profile/* as root #1178

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

marc-hb
Copy link
Collaborator

@marc-hb marc-hb commented Apr 22, 2024

Fixes commit 46219fa ("case-lib/lib.sh: use sudo to access debugfs files")

Fixes commit 46219fa ("case-lib/lib.sh: use sudo to access debugfs
files")

Signed-off-by: Marc Herbert <[email protected]>
@marc-hb
Copy link
Collaborator Author

marc-hb commented Apr 22, 2024

Breaking news: testing find bugs. If you ever run out of bugs, just test a bit harder. There's an infinite supply!

Notably this fw_lib_path kernel OOPS @plbossart:

Keeping as draft until the oops is fixed.

At least MTL https://sof-ci.01.org/softestpr/PR1178/build323/devicetest/index.html did not uncover any bug and is all green! The values are also printed now as expected.

@marc-hb marc-hb marked this pull request as ready for review April 22, 2024 23:52
@marc-hb marc-hb requested a review from a team as a code owner April 22, 2024 23:52
@marc-hb marc-hb marked this pull request as draft April 22, 2024 23:53
@marc-hb
Copy link
Collaborator Author

marc-hb commented Apr 23, 2024

@marc-hb
Copy link
Collaborator Author

marc-hb commented Apr 25, 2024

SOFCI TEST

@marc-hb marc-hb requested review from plbossart and ujfalusi April 25, 2024 07:06
@marc-hb
Copy link
Collaborator Author

marc-hb commented Apr 25, 2024

Some test results missing but plenty enough of expected logs with both IPC3 and IPC4, merging.

@marc-hb marc-hb merged commit 194070a into thesofproject:main Apr 25, 2024
5 of 7 checks passed
@marc-hb marc-hb deleted the expand-fw-profile branch April 25, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants