Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amixer setting for ipc4 platforms #1012

Merged
merged 2 commits into from
Mar 29, 2023

Conversation

keqiaozhang
Copy link
Contributor

No description provided.

@marc-hb
Copy link
Collaborator

marc-hb commented Mar 15, 2023

Fix for one of the shellcheck warnings suggested in #1010 (comment)

https://github.com/thesofproject/sof-test/actions/runs/4424462565/jobs/7758320869

This other one is pretty good:

In case-lib/lib.sh line 811:
        APL_UP2_NOCODEC | CML_RVP_NOCODEC | JSL_RVP_NOCODEC |
TGLU_RVP_NOCODEC | ADLP_RVP_NOCODEC | TGLH_RVP_NOCODEC | MTLP_RVP_NOCODEC)



         ^--------------^ SC2221: This pattern always overrides a later one on line 819.

@keqiaozhang keqiaozhang marked this pull request as ready for review March 17, 2023 07:45
@keqiaozhang keqiaozhang requested a review from a team as a code owner March 17, 2023 07:45
@keqiaozhang
Copy link
Contributor Author

#1010 should be merged first.

@miRoox
Copy link
Contributor

miRoox commented Mar 28, 2023

Rebase?

@keqiaozhang
Copy link
Contributor Author

Rebase?

Done.

Copy link
Contributor

@miRoox miRoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice the amixer settings depend on the model in an incompatible way with the hardware/software config. But anyway, we can consider this later.

@keqiaozhang keqiaozhang merged commit 02aafc0 into thesofproject:main Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants