Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASoC: SOF: ipc3-topology: subtract ALH dai_index by 2 #5217

Open
wants to merge 2 commits into
base: topic/sof-dev
Choose a base branch
from
Open

ASoC: SOF: ipc3-topology: subtract ALH dai_index by 2 #5217

wants to merge 2 commits into from
+41 −2

Commits on Oct 25, 2024

  1. ASoC: SOF: ipc3-topology: normalize ALH dai_index 

    Intel SoundWire machine driver always use bidirectional DAIs. And the
DAI index starts from 2. However, SOF IPC3 firmware assume all DAIs
are bidirectional and the index starts from 0. As a result, FW DAI 0
and 1 are never used. That worked fine because we use up to 2 DAIs in
a SDW link. But, a multi-function SDW codec needs to use 4 DAIs and
some platforms like Tiger Lake supports 4 bidirectional DAIs in each
SDW link. That means all bidirectional DAIs include DAI 0 and 1 will
be used. Therefore, we need to subtract ALH dai_index by 2 which is the
base of bidirectional DAIs.

IOW, currently, SDW0 Pin 2 which is the first bidirectional SDW Pin
will use FW DAI 2. But FW DAI 4 is invalid. With this commit SDW0 Pin 2
will use FW DAI 0 and SDW0 Pin 5 will use FW DAI 3 which is valid.

Add a base to sof_dev_desc{} so we can normalize the index.

The issue exists since beginning. And the Fixes tag is the first commit
that this commit can be applied.

Fixes: b66bfc3 ("ASoC: SOF: sof-audio: Fix broken early bclk feature for SSP")
Signed-off-by: Bard Liao <[email protected]>
    @bardliao
    bardliao committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    6c30878 View commit details
    Browse the repository at this point in the history

  2. ASoC: SOF: Intel: set bidirectional SDW base 

    Intel SoundWire machine driver always use bidirectional DAIs. However,
SOF IPC3 firmware assume all DAIs are bidirectional and the index starts
from 0. Set the base which will be used in ipc3 topology functions. So
that IPC3 firmware can use DAI 0, 1, and so on.

Signed-off-by: Bard Liao <[email protected]>
    @bardliao
    bardliao committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    f8fca0e View commit details
    Browse the repository at this point in the history