Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASoC: SOF: Intel: hda: fix null deref on system suspend entry #5085

Merged

Commits on Jun 26, 2024

  1. ASoC: SOF: Intel: hda: fix null deref on system suspend entry

    When system enters suspend with an active stream, SOF core
    calls hw_params_upon_resume(). On Intel platforms with HDA DMA used
    to manage the link DMA, this leads to call chain of
    
       hda_dsp_set_hw_params_upon_resume()
     -> hda_dsp_dais_suspend()
     -> hda_dai_suspend()
     -> hda_ipc4_post_trigger()
    
    A bug is hit in hda_dai_suspend() as hda_link_dma_cleanup() is run first,
    which clears hext_stream->link_substream, and then hda_ipc4_post_trigger()
    is called with a NULL snd_pcm_substream pointer.
    
    Fixes: 2b009fa ("ASoC: SOF: Intel: hda: Unify DAI drv ops for IPC3 and IPC4")
    Link: thesofproject#5080
    Signed-off-by: Kai Vehmanen <[email protected]>
    kv2019i committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    b47d0c8 View commit details
    Browse the repository at this point in the history