fixup! ASoC: SOF: topology: dynamically allocate and store DAI widget… #4724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ujfalusi
requested review from
lgirdwood,
plbossart,
ranj063,
kv2019i,
dbaluta and
bardliao
as code owners
…->private Prevent NULL pointer dereference when freeing the DAI widgets in DSPless mode. commit b0490cc ("ASoC: SOF: topology: dynamically allocate and store DAI widget->private") now sets swidget->priv to non NULL so the sof_widget_free_unlocked() is executed and we get a NULL dereference when reaching to swidget->spipe->pipe_widget Signed-off-by: Peter Ujfalusi <[email protected]>
plbossart
approved these changes
Nov 30, 2023
ranj063
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…->private
Prevent NULL pointer dereference when freeing the DAI widgets in DSPless mode.
commit b0490cc ("ASoC: SOF: topology: dynamically allocate and store DAI widget->private") now sets swidget->priv to non NULL so the sof_widget_free_unlocked() is executed and we get a NULL dereference when reaching to swidget->spipe->pipe_widget