ASoC: tas2781: Add tas2783 driver #4700
Conversation
Signed-off-by: Shenghao Ding <[email protected]>
Shenghao-Ding
requested review from
lgirdwood,
plbossart,
ranj063,
kv2019i,
dbaluta,
bardliao,
ujfalusi,
vijendarmukunda,
kuanhsuncheng and
yaochunhung
as code owners
|
Can one of the admins verify this patch?
|
|
@Shenghao-Ding Please split the commit into 1. codec driver 2. The machine driver change (sof_sdw.c) 3. The acpi_mach change (soc-acpi-intel-mtl/tgl-match.c) |
| @@ -587,6 +611,12 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_mtl_sdw_machines[] = { | |||
| .drv_name = "sof_sdw", | |||
| .sof_tplg_filename = "sof-mtl-rt713-l0-rt1316-l12.tplg", | |||
| }, | |||
| { | |||
| .link_mask = 0xf, //HACK for all sdw links are enabled | |||
There was a problem hiding this comment.
It should be BIT(x) in the upstream version.
| } | ||
| }; | ||
|
|
||
| static const struct snd_soc_acpi_link_adr tas2783_link1[] = { |
There was a problem hiding this comment.
Please rename tas2783_link1[] to tas2783_link0[] as the amp is on link 0, and so does tas2783_1_adr[]
|
test this please |
sound/soc/codecs/tas2783.h
Outdated
| * https://www.ti.com | ||
| * | ||
| * The TAS2783 driver implements a flexible and configurable | ||
| * algo coff setting for single TAS2783 chips. |
There was a problem hiding this comment.
please take review comments into account, it must be the 4th time I write down that 'coff' is a typo for 'coeff' or 'coefficient'
sound/soc/codecs/tas2783-sdw.c
Outdated
|
|
||
| stream = kzalloc(sizeof(*stream), GFP_KERNEL); | ||
| if (!stream) | ||
| return -ENOMEM; |
There was a problem hiding this comment.
no, it's also the 3rd time I write down that this is not necessary. see the simplifications done for all other codecs.
I stop the review here since this is the same code that's submitted for review WITHOUT ANY CHANGES
|
Erm, please don't add merge commits in your branch. You need to rebase on top of topic/sof-dev, then use git push --force for any update. |
Signed-off-by: Shenghao Ding <[email protected]> --- Change in v2: - simplify tasdevice_set_sdw_stream - fixed some Linux coding style - fixed the spelling mistakes
Signed-off-by: Shenghao Ding <[email protected]> --- Change in v2: - Add machine driver for tas2783
Signed-off-by: Shenghao Ding <[email protected]> --- Change in v2: - modify the 0xf to GENMASK(3, 0) - modify tas2783_link1 to tas2783_link0 - modify tas2783_1_adr to tas2783_0_adr
|
I don't follow how you are using GitHub... Please remove all merge commits and squash all changes. when you have a new version, please use "git push --force" to make sure we ONLY see the latest contribution - similar to what you would do when sending a patchset upstream on alsa-devel. |
| mfg_id, part_id, class_id); | ||
| else | ||
| codec->name = devm_kasprintf(dev, GFP_KERNEL, | ||
| "sdw:0:%01x:%04x:%04x:%02x:%01x", link_id, | ||
| "sdw:%01x:%04x:%04x:%02x:%01x", link_id, |
|
test this please |
|
lots of checkpatch issues @Shenghao-Ding Fixing them will also deal with quite a few review comments already |
|
closing, no updates from TI |
Support both TX and RX.