ASoC: Intel: sof_maxim_common: check return value #4695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bardliao
requested review from
lgirdwood,
plbossart,
ranj063,
kv2019i,
dbaluta,
vijendarmukunda,
kuanhsuncheng and
yaochunhung
as code owners
brentlu
previously approved these changes
Nov 9, 2023
aiChaoSONG
previously approved these changes
Nov 9, 2023
plbossart
approved these changes
Nov 10, 2023
|
bardliao
force-pushed
the
sof_maxim_common
branch
from
3b29f88 to
a97f67a
Compare
Fixed |
bardliao
force-pushed
the
sof_maxim_common
branch
2 times, most recently
from
ea9c131 to
016734d
Compare
if (!strcmp(codec_dai->component->name, MAX_98373_DEV0_NAME)) and if (!strcmp(codec_dai->component->name, MAX_98373_DEV1_NAME)) can't be true at the same time. Add an else to clarify it. Signed-off-by: Bard Liao <[email protected]>
snd_soc_dai_set_tdm_slot() could return error. Signed-off-by: Bard Liao <[email protected]>
aiChaoSONG
approved these changes
Nov 10, 2023
plbossart
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
snd_soc_dai_set_tdm_slot() could return error, and add an else to clarify that
if (!strcmp(codec_dai->component->name, MAX_98373_DEV0_NAME))andif (!strcmp(codec_dai->component->name, MAX_98373_DEV1_NAME))can't be true at the same time.