ASoC: SOF: imx8m: Add MICFIL PDM interface #4670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow creating of PDM DAI links. Signed-off-by: Daniel Baluta <[email protected]>
dbaluta
requested review from
ranj063,
singalsu,
bardliao,
lyakh,
lgirdwood,
plbossart,
kv2019i,
ujfalusi,
vijendarmukunda,
kuanhsuncheng and
yaochunhung
as code owners
plbossart
approved these changes
Oct 31, 2023
| @@ -51,4 +51,11 @@ struct sof_ipc_dai_sai_params { | |||
| uint16_t tdm_slot_width; | |||
There was a problem hiding this comment.
Please rephrase the commit message, for this patch, maybe "Add support for configuring PDM interface from topology".
Other than that, LGTM.
There was a problem hiding this comment.
@iuliana-prodan updated commit message as you suggested.
Currently we only support configuration for number of channels and sample rate. Signed-off-by: Daniel Baluta <[email protected]>
iuliana-prodan
approved these changes
Nov 3, 2023
ujfalusi
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add MICFIL configuration to support MICFIL PDM DAI on i.MX8MP.