ASoC: Intel: skl_hda_dsp_generic: Drop HDMI routes when HDMI is not a… #4649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ujfalusi
requested review from
lgirdwood,
plbossart,
ranj063,
kv2019i,
dbaluta,
bardliao,
vijendarmukunda,
kuanhsuncheng and
yaochunhung
as code owners
|
@plbossart, @keqiaozhang, this patch will likely fix #4648 and it is also going to unblock #4620 We create dummy codec in case of HDMI is not available but we still had the routes and that is what fails. Trimming the routes will allow the card to probe and have the dummy HDMI PCMs (they are described in tplg and we cannot filter them out). |
bardliao
approved these changes
Oct 23, 2023
ujfalusi
force-pushed
the
peter/sof/pr/hda_generic_trim_hdmi_01
branch
from
19259e2 to
19e6a95
Compare
…vailable When the HDMI is not present due to disabled display support we will use dummy codec and the HDMI routes will refer to non existent DAPM widgets. Trim the route list from the HDMI routes to be able to probe the card even if the HDMI dais are not registered. Signed-off-by: Peter Ujfalusi <[email protected]>
|
Changes since v1:
|
kv2019i
approved these changes
Oct 23, 2023
plbossart
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…vailable
When the HDMI is not present due to disabled display support
we will use dummy codec and the HDMI routes will refer to non existent
DAPM widgets.
Trim the route list from the HDMI routes to be able to probe the card even
if the HDMI dais are not registered.