-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dApp: Implement total Acre Points pool balance #841
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for acre-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for acre-dapp-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Use constant value for debounce threshold
r-czajkowski
previously approved these changes
Nov 12, 2024
Approved but converted this PR to draft. We need to deploy the backend first with the updated endpoint. |
r-czajkowski
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #804
Ref: https://github.com/thesis/acre-bots/pull/51
This pull request introduces several enhancements to the Acre Points feature, including the addition of a total pool balance, periodic data refetching, and improved user interface elements.
Changes
dapp/src/hooks/useAcrePoints.ts
: AddedtotalPoolBalance
to the return type ofuseAcrePoints
and included a periodic data refetch interval usingREFETCH_INTERVAL_IN_MILLISECONDS
.dapp/src/pages/DashboardPage/AcrePointsCard.tsx
: UpdatedAcrePointsCard
to display the total pool balance when the wallet is disconnected and modified the tooltip to provide context-sensitive information.dapp/src/utils/acreApi.ts
: ModifiedgetPointsData
to includetotalPool
in the response.Preview