Add Welcome component #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for acre-dapp-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for acre-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
r-czajkowski
commented
Nov 8, 2024
kpyszkowski
previously requested changes
Nov 8, 2024
kkosiorowska
reviewed
Nov 8, 2024
Use react router loaders to display modals in correct order. We want to display welcome modal after access code modal in standalone app and before wallet connection in embedded apps.
To emphasize the fragment of text.
Remove border based on the Figma views - now none of the modals have a border.
Pull up the `WelcomeModal/index.ts` file one level higher - keep the component code in `src/components/WelcomeModal.tsx` file.
Display conntent based on the embedded app.
Use `mp4` files.
Set correct border radius for the video box. We should make rounded corners only on the right side to fit the modal dialog.
Comment on lines
+131
to
+135
| // Cast to fix eslint error: `unbound-method`. | ||
| const { activeStep, goToNext } = useSteps({ | ||
| index: 0, | ||
| count: steps.length, | ||
| }) as UseStepsReturn & { goToNext: () => void } |
There was a problem hiding this comment.
We should probably update the Chakra package, see here. But let's leave it as it is for now.
There was a problem hiding this comment.
Yeah. But it's not a good time to update main packages just before the release.
Remove no longer needed border styles. We do not want to display border for the modal component.
We already have a file for router utils. Let's keep everything in one file.
There is no need to send the request to acre api to verify access code if the access code from local storage is `undefined` - it means the access code is invalid and we can skip the validation.
In some cases we render different content layouts etc depnding on whether it is an embedded or standalone application. Here we introduce the `DappMode` type to simplify code and organize the dapp modes.
kkosiorowska
dismissed
kpyszkowski’s stale review
The requests have been implemented.
kkosiorowska
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #824
Closes: AENG-1
This PR adds a
Welcomecomponent based on the Figma views. Here we are also updating how we display modal in the correct order - we use react router loaders to display modals in the correct order. We want to display the welcome component after the access code modal in a standalone app and before the wallet connection in embedded apps.Screenshots