-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dApp: Deposit limit when TVL cap is exceeded #826
Conversation
✅ Deploy Preview for acre-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for acre-dapp-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I left only one question and non-blocking comment.
- When the flag is disabled and the user is not connected, we do not display the withdraw button. Currently we always display two buttons. Are we sure we want to change it?
- I think we could improve a bit the loading of elements in the following component. What I mean is that when the user is not connected can see a button and text then later the text disappears and two buttons appear. I think we could add maybe a skeleton for all this row? Of course, this is a non-blocking comment, let's think about it later.
Screen.Recording.2024-11-07.at.14.30.20.mov
It was consulted with Design team and it was confirmed that the Withdrawal button should be hidden under specific conditions. (context)
I considered it. The purpose of skeletons is to provide a placeholder for content that is not ready yet. |
@kpyszkowski does this PR address #805? |
Closes: #827
Closes: #805
Changes:
Preview:
Note:
To start with latest TVL changes I set the origin branch totvl-component
.src/constants/staking.ts
file.