[nft-collection N-06] Variables Initialized With Their Default Values #1638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adjisb
force-pushed
the
fix/nft-collection-audit-N-05
branch
from
564156e to
acff357
Compare
adjisb
force-pushed
the
fix/nft-collection-audit-N-06
branch
from
6d1e4c1 to
e389954
Compare
adjisb
force-pushed
the
fix/nft-collection-audit-N-05
branch
from
acff357 to
cd2cb6b
Compare
adjisb
force-pushed
the
fix/nft-collection-audit-N-06
branch
from
e389954 to
98479d8
Compare
wojciech-turek
approved these changes
Jan 29, 2025
adjisb
force-pushed
the
fix/nft-collection-audit-N-05
branch
from
cd2cb6b to
98da5be
Compare
adjisb
force-pushed
the
fix/nft-collection-audit-N-06
branch
from
98479d8 to
859b5b9
Compare
adjisb
force-pushed
the
fix/nft-collection-audit-N-05
branch
from
98da5be to
7d403af
Compare
adjisb
force-pushed
the
fix/nft-collection-audit-N-06
branch
from
859b5b9 to
f48ab45
Compare
adjisb
force-pushed
the
fix/nft-collection-audit-N-05
branch
from
7d403af to
2a51453
Compare
adjisb
force-pushed
the
fix/nft-collection-audit-N-06
branch
from
f48ab45 to
d43c6c3
Compare
adjisb
force-pushed
the
fix/nft-collection-audit-N-06
branch
from
d43c6c3 to
6059d50
Compare
adjisb
changed the base branch from
fix/nft-collection-audit-N-05
to
fix/nft-collection-audit-N-03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://internal-jira.atlassian.net/browse/GE-100
Audit
Within NFTCollection.sol, multiple instances of variables being initialized with their default values were identified:
The i variable in the safeBatchTransferFrom function
The i variable in the batchTransferFrom function
To save gas, consider not initializing variables with their default values.
Fixes
Fixes, removed the initialization.