[nft-collection L-03] Absence of whenNotPaused Modifiers for Several Functions #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adjisb
changed the title
adjisb
changed the title
wojciech-turek
approved these changes
Jan 29, 2025
adjisb
force-pushed
the
fix/nft-collection-audit-L-02
branch
from
11f48e7 to
083bec5
Compare
adjisb
force-pushed
the
fix/nft-collection-audit-L-03
branch
from
eb8cd5b to
4f7bdac
Compare
adjisb
force-pushed
the
fix/nft-collection-audit-L-02
branch
from
083bec5 to
cb9e6fd
Compare
adjisb
force-pushed
the
fix/nft-collection-audit-L-03
branch
from
4f7bdac to
e9bd12f
Compare
adjisb
force-pushed
the
fix/nft-collection-audit-L-02
branch
from
cb9e6fd to
35f536d
Compare
adjisb
force-pushed
the
fix/nft-collection-audit-L-03
branch
2 times, most recently
from
a13891a to
f573fca
Compare
adjisb
force-pushed
the
fix/nft-collection-audit-L-02
branch
from
35f536d to
dfba957
Compare
added 2 commits
February 3, 2025 13:22
We don't pause ownerOnly operations because it gives us the power to fix issues. TODO: decide if we want to pause those too.
adjisb
force-pushed
the
fix/nft-collection-audit-L-03
branch
from
f573fca to
7880589
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://internal-jira.atlassian.net/browse/GE-100
Audit
The NFTcollection contract will enter a paused state upon invocation of the pause function. However, several non-view functions, for example, the operatorPersonalize, transferFrom, safeTransferFrom, batchTransferFrom, and safeBatchTransferFrom functions, lack the whenNotPaused modifier and will remain operational even when the contract has been paused.
Consider adding the whenNotPaused modifier to all the non-view functions within the NFTcollection contract.
Fix