[nft-collection L-01] Misuse of sender in _burnWithCheck Function #1627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adjisb
changed the title
adjisb
changed the title
adjisb
changed the title
packages/avatar/contracts/nft-collection/ERC721BurnUpgradeable.sol
Outdated
Show resolved
Hide resolved
packages/avatar/contracts/nft-collection/ERC721BurnUpgradeable.sol
Outdated
Show resolved
Hide resolved
adjisb
force-pushed
the
fix/nft-collection-audit-L-01
branch
from
28c45de to
d51749e
Compare
wojciech-turek
approved these changes
Jan 29, 2025
adjisb
changed the base branch from
fix/nft-collection-audit-M-01
to
fix/nft-collection-remove-amount-from-signature
adjisb
force-pushed
the
fix/nft-collection-remove-amount-from-signature
branch
3 times, most recently
from
d8f13ea to
957a469
Compare
added 2 commits
February 3, 2025 13:19
WIP: we must stil need to decide if we want to have burn() and
if we want to be able to enable/disable it
adjisb
force-pushed
the
fix/nft-collection-audit-L-01
branch
from
7626abc to
80c9b27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://internal-jira.atlassian.net/browse/GE-100
Audit
The burnedTokens mapping records the burned NFT tokens for each burner address. The didBurnTokens, burnedTokensCount, and burnedTokens functions take the NFT owner previousOwner as a parameter and utilize it as the index for burnedTokens to retrieve information.
However, within the _burnWithCheck function, when recording the burned NFT token in burnedTokens, the index is incorrectly set to sender, who initiates the action, rather than previousOwner, who is the actual owner of the burned token. This discrepancy could result in misleading return values from the aforementioned view functions.
When setting a value in the burnedTokens mapping, consider using previousOwner instead of sender in the _burnWithCheck function.
Fix
We completely removed the burn tracking