Revert "Update for Xcode 14.3, use private module" #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 556ca6f
uroboro
approved these changes
May 18, 2024
uroboro
approved these changes
May 22, 2024
L1ghtmann
approved these changes
May 25, 2024
kabiroberai
approved these changes
May 25, 2024
There was a problem hiding this comment.
LGTM, @leptos-null feel free to merge if you have permission — otherwise lmk and I can do it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This reverts commit 556ca6f
The changes made in the referenced commit do not seem to be compatible with { Xcode 11/ the associated Swift version } which is used for releases:
orion/.github/workflows/release.yml
Line 38 in dd60a11
Does this close any currently open issues?
Yes: #32
Any relevant logs, error output, etc?
No
Any other comments?
Added #34 to avoid issues in the future where "tests" passes for code that will not work on the "release" workflow.
Where has this been tested?
Operating System: macOS
Platform: Darwin
Target Platform: iOS
Toolchain Version: Xcode 11.7
SDK Version: 13