add function_checksum_is #153
Open
+699
−549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder... With pgTAP, shouldn't one be checking the behavior of a function? This seems more like an audit rule than test assertion. |
|
Awesome, care to add some tests to |
|
@cbandy pgTAP has no religion about the type of testing you do, but likes to give you the tools to do your testing well. |
|
Took me a while, but here it is :) |
|
Look unhappy on Postgres 10. :-( |
|
Yes but is seems to fail on partitions… which I didn't touch... |
Closed
marco44
force-pushed
the
function_checksum_is
branch
from
6e301e1 to
46665c7
Compare
added 2 commits
March 23, 2018 15:59
marco44
force-pushed
the
function_checksum_is
branch
from
46665c7 to
29dea23
Compare
|
Please merge master; it has fixes for some bugs as well as much better test capabilities. |
|
Also, this needs documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, As discussed in theory/tap-parser-sourcehandler-pgtap#18, here is a PR to add function_checksum_is
I didn't like joining to pg_proc, but couldn't find a better idea without extending tap_funky.