Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redesign shopping cards #67

Merged
merged 1 commit into from
Jun 16, 2023
Merged

redesign shopping cards #67

merged 1 commit into from
Jun 16, 2023

Conversation

fsoussand
Copy link
Collaborator

@fsoussand fsoussand commented Jun 2, 2023

What is this pull request doing ?

#60
We redesign the cards

Screenshot

Capture d’écran 2023-06-09 à 16 03 40 Capture d’écran 2023-06-09 à 16 04 03

How is it done ?

How to test ?

@netlify
Copy link

netlify bot commented Jun 2, 2023

Deploy Preview for a11yinyerface ready!

Name Link
🔨 Latest commit 054ccfd
🔍 Latest deploy log https://app.netlify.com/sites/a11yinyerface/deploys/648885c2f3319d0008eeb3a4
😎 Deploy Preview https://deploy-preview-67--a11yinyerface.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@fsoussand

This comment was marked as resolved.

@fsoussand

This comment was marked as resolved.

@fsoussand

This comment was marked as resolved.

@fsoussand fsoussand force-pushed the modify-cards-design branch from f4566c3 to 140d685 Compare June 9, 2023 10:19
@RobinCar
Copy link
Collaborator

RobinCar commented Jun 9, 2023

Les cartes sont pas de la même taille dans les 2 styles ?

@RobinCar
Copy link
Collaborator

RobinCar commented Jun 9, 2023

Il y a un problème avec le déploiement, jene vois pas le bouton + et le menu ne s'ouvre pas

@fsoussand
Copy link
Collaborator Author

fsoussand commented Jun 9, 2023

Les cartes sont pas de la même taille dans les 2 styles ?
Non elles n'ont pas la mêmes taille car pour garder des images carrées avec la même hauteur, j'ai diminué la largeur
Mais comme il y a plus d'infos sur les 'tiny button', je ne trouve pas forcément ca génant. T'en penses quoi ?

@fsoussand fsoussand force-pushed the modify-cards-design branch from 140d685 to c925004 Compare June 13, 2023 14:48
@fsoussand fsoussand force-pushed the modify-cards-design branch from c925004 to 054ccfd Compare June 13, 2023 15:05
@fsoussand fsoussand merged commit eb147ee into main Jun 16, 2023
@fsoussand fsoussand deleted the modify-cards-design branch June 16, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants