Add ZendFramework 1 support #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| BagManagerConfigurationInterface::LAST_REQUEST_NAMESPACE => 'symfony/user/sfUser/lastRequest', | ||
| BagManagerConfigurationInterface::AUTH_NAMESPACE => 'symfony/user/sfUser/authenticated', | ||
| BagManagerConfigurationInterface::CREDENTIAL_NAMESPACE => 'symfony/user/sfUser/credentials', | ||
| BagManagerConfigurationInterface::CULTURE_NAMESPACE => 'symfony/user/sfUser/culture', | ||
| ); | ||
|
|
||
| private $zf1Namespaces; | ||
|
|
||
| public function __construct($zf1MainNamespace, $zf1Namespaces) { |
There was a problem hiding this comment.
Please add type hint: array $zf1Namespaces
There was a problem hiding this comment.
And please add PHPDoc every where
|
IMO we should not create a new item in the configuration to add namespaces for a specific framework. In the end the configuration would look like (and taking into account my remark in #12: theodo_evolution_session:
bag_manager: theodo_evolution.session. zendframework1_bag_manager
bag_manager_configuration: theodo_evolution.session. zendframework1_bag_manager_configuration
namespace:
- foo
- bar And it will symplify a LOT of code in the extension too 😄 |
|
This is a great idea 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress to add ZendFramework 1 support into TESessionBundle