Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds an option to set a custom directory for the fonts folder. #2470

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EngKhaledB
Copy link

@EngKhaledB EngKhaledB commented Feb 22, 2022

The issue:

For read-only hosting like Pantheon for example, they prevent php from writing any file outside uploads directory.
So that, a lot of php errors happens because of no write permissions.

The Fix:

I added an option to set a custom fonts directory via constant variable named KIRKI_FONTS_DIR.

@contactjavas
Copy link
Contributor

Hi @EngKhaledB , good suggestion!
I'm not sure if we should use constant or filter for that. What do you think @mapsteps ?

Oh, maybe we forgot to mention that this repo contains individual controls.
The real developments are in the individual repositories.
So this PR should be in kirki-framework/module-webfonts repository.

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants