Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix network not available on boot #12

Closed
wants to merge 1 commit into from
Closed

Fix network not available on boot #12

wants to merge 1 commit into from

Conversation

Superpiffer
Copy link
Contributor

Very often, on boot, TheLounge cannot connect to channels because network is not available yet. Use network-online.target solves the problem.

@brunnre8
Copy link
Member

brunnre8 commented Apr 4, 2019

Do you have some examples where this is done on Arch? even apache just depends on network.target

the freedesktop docs also say

It is strongly recommended not to pull in this target too liberally: for example network server software should generally not pull this in (since server software generally is happy to accept local connections even before any routable network interface is up)

@xPaw
Copy link
Member

xPaw commented Apr 4, 2019

I agree with @brunnre8 it's not entirely a good idea to use this.

I suggest creating an issue in https://github.com/kiwiirc/irc-framework/issues suggesting to enable auto reconnects for specific socket errors like (EHOSTUNREACH), but even then I'm not sure if that's a good idea either.

@Superpiffer
Copy link
Contributor Author

Superpiffer commented Apr 4, 2019

Ok, I'm already using an override so there's no problem for me. So? It's a limitation of the framework and there's nothing we can do? When my server restarts, I have to connect manually to my channels every time...

@brunnre8
Copy link
Member

brunnre8 commented Apr 4, 2019

there's already an issue open about it kiwiirc/irc-framework#178

Or not quite but similar enough I guess

@Superpiffer
Copy link
Contributor Author

Superpiffer commented Apr 4, 2019

Do you have some examples where this is done on Arch? even apache just depends on network.target

the freedesktop docs also say

It is strongly recommended not to pull in this target too liberally: for example network server software should generally not pull this in (since server software generally is happy to accept local connections even before any routable network interface is up)

BTW I just checked, nginx has both targets in the service file from the official package: https://git.archlinux.org/svntogit/packages.git/tree/trunk/service?h=packages/nginx

@brunnre8
Copy link
Member

brunnre8 commented Apr 8, 2019

Closing as per the discussion above.

but thanks for the PR anyhow, it's appreciated

@brunnre8 brunnre8 closed this Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants