bug fixes and optimizations

- setting changes no longer create multiple triggers and parallel data refresh tasks - fix error "TypeError: symbolCustomization is undefined" - honor custom names in sorting - move refresh button to the bottom of the screen - minor refactoring and cleanup
thegli · Aug 25, 2024 · 057d341 · 057d341
1 parent 02d8a3e
commit 057d341
Show file tree

Hide file tree

Showing 17 changed files with 461 additions and 475 deletions.
diff --git a/README.md b/README.md
@@ -23,6 +23,9 @@ Either follow the installation instructions on [Cinnamon spices](https://cinnamo
 
 Check out the desklet configuration settings, and choose the data refresh period, the list of quotes to show, and quote details to display. The default list contains the Dow 30 companies.
 
+> Note that **any changes in the quotes list are not applied immediately** (anymore). This is true for manual changes as well as for import settings from a file.  
+Press the "Refresh quotes data" button to execute an immediate data update, or wait until the next automatic refresh is triggered (depending on the configured interval).
+
 ### Individual Quote Design
 
 By default, all quotes in the list are rendered in the same style and color, following whatever settings are active and selected.  
@@ -42,7 +45,7 @@ The following table explains all supported properties:
 
 Some examples:
 
-```
+```text
 CAT;color=#f6d001;weight=500
 CSCO;name=Cisco;weight=bold;color=#00bceb
 HD;color=#f96300
@@ -51,8 +54,6 @@ IBM;name=Big Blue;color=blue;weight=bolder
 KO;name=Bubbly Brown Water;style=oblique;weight=lighter;color=#e61a27
 ```
 
-> Note that any changes in the quotes list are not applied immediately (anymore). Press the "Refresh quotes data" button to trigger a manual data update for the current quotes list.
-
 ## Troubleshooting
 
 Problem: The desklet fails to load data, and shows error message "Status: 429 Too Many Requests".  
@@ -72,12 +73,27 @@ To disable the debug log mode, delete the "DEBUG" file, and restart the Cinnamon
 
 ## Release Notes
 
+### 0.14.1 - August 25, 2024
+
+Features:
+
+- setting changes no longer trigger data refresh cycles, resulting in faster layout rendering and reduced network traffic
+- update Catalan translation (courtesy of [Odyssey](https://github.com/odyssey))
+- update Spanish translation (courtesy of [haggen88](https://github.com/haggen88))
+
+Bugfixes:
+
+- prevent spawning multiple data fetching tasks at the same time
+- prevent creation of more than one data refresh timer
+- fix error "TypeError: symbolCustomization is undefined"
+- honor custom names in sorting
+
 ### 0.14.0 - August 21, 2024
 
 Features:
 
 - style each quote individually - see section [Individual Quote Design](#individual-quote-design) for details
-- add Catalan translation (courtesy of [Odyssey]((https://github.com/odyssey))
+- add Catalan translation (courtesy of [Odyssey](https://github.com/odyssey))
 - update Dutch translation (courtesy of [qadzek](https://github.com/qadzek))
 - update Hungarian translation (courtesy of [bossbob88](https://github.com/bossbob88))
 - update Spanish translation (courtesy of [haggen88](https://github.com/haggen88))

diff --git a/files/yfquotes@thegli/desklet.js b/files/yfquotes@thegli/desklet.js
diff --git a/files/yfquotes@thegli/metadata.json b/files/yfquotes@thegli/metadata.json
@@ -3,6 +3,6 @@
     "name": "Yahoo Finance Quotes",
     "prevent-decorations": true,
     "max-instances": "10",
-    "version": "0.14.0",
+    "version": "0.14.1",
     "uuid": "yfquotes@thegli"
 }
diff --git a/files/yfquotes@thegli/po/ca.po b/files/yfquotes@thegli/po/ca.po
@@ -8,7 +8,7 @@ msgstr ""
 "Project-Id-Version: yfquotes@thegli 0.13.0\n"
 "Report-Msgid-Bugs-To: https://github.com/linuxmint/cinnamon-spices-desklets/"
 "issues\n"
-"POT-Creation-Date: 2024-08-21 22:58+0200\n"
+"POT-Creation-Date: 2024-08-25 22:42+0200\n"
 "PO-Revision-Date: 2024-08-22 20:58+0200\n"
 "Last-Translator: Odyssey <[email protected]>\n"
 "Language-Team: \n"
@@ -18,61 +18,57 @@ msgstr ""
 "Content-Transfer-Encoding: 8bit\n"
 "X-Generator: Poedit 3.4.2\n"
 
-#. desklet.js:321
+#. desklet.js:79
+msgid "No quotes data to display"
+msgstr ""
+
+#. desklet.js:399
 msgid "Empty quotes list. Open settings and add some symbols."
 msgstr ""
 "Llista de cotitzacions buida. Obriu la configuració i afegiu-hi alguns "
 "símbols."
 
-#. desklet.js:343 desklet.js:362
+#. desklet.js:421 desklet.js:440
 msgid "Yahoo Finance service not available!\\nStatus: "
 msgstr "El servei de Yahoo finances no està disponible!\\nEstat: "
 
-#. desklet.js:767
+#. desklet.js:795
 msgid "Updated at "
 msgstr "Actualitzat a les "
 
-#. desklet.js:788
+#. desklet.js:828
 msgid "Error: "
 msgstr "Error: "
 
-#. desklet.js:892
+#. desklet.js:925
 msgid ""
 "Failed to retrieve authorization parameter! Unable to fetch quotes data."
 "\\nStatus: "
 msgstr ""
 "Error en recuperar el paràmetre d'autorització. No s'han pogut obtenir les "
 "dades de les cotitzacions.\\nEstat: "
 
-#. desklet.js:917
+#. desklet.js:950
 msgid "Consent processing failed! Unable to fetch quotes data.\\nStatus: "
 msgstr ""
 "No s'ha pogut processar el consentiment! No s'han pogut obtenir les dades de "
 "les cotitzacions.\\nEstat: "
 
-#. desklet.js:922
+#. desklet.js:955
 msgid ""
 "Consent processing not completed! Unable to fetch quotes data.\\nStatus: "
 msgstr ""
 "No s'ha completat el processament del consentiment. No s'han pogut obtenir "
 "les dades de les cotitzacions.\\nEstat: "
 
-#. desklet.js:944
+#. desklet.js:977
 msgid ""
 "Failed to retrieve authorization crumb! Unable to fetch quotes data."
 "\\nStatus: "
 msgstr ""
 "No s'ha pogut recuperar la ruta d'autorització! No s'han pogut obtenir les "
 "dades de les cotitzacions.\\nEstat: "
 
-#. desklet.js:983
-msgid "Cannot display quotes information for symbols: "
-msgstr "No es pot mostrar la informació de les cotitzacions pels símbols: "
-
-#. desklet.js:984
-msgid "The following error occurred: "
-msgstr "Hi ha hagut el següent error: "
-
 #. metadata.json->description
 msgid ""
 "Displays financial market information such as stock quotes and commodity "

diff --git a/files/yfquotes@thegli/po/da.po b/files/yfquotes@thegli/po/da.po
@@ -7,7 +7,7 @@ msgstr ""
 "Project-Id-Version: \n"
 "Report-Msgid-Bugs-To: https://github.com/linuxmint/cinnamon-spices-desklets/"
 "issues\n"
-"POT-Creation-Date: 2024-08-21 22:58+0200\n"
+"POT-Creation-Date: 2024-08-25 22:42+0200\n"
 "PO-Revision-Date: 2023-12-08 08:06+0100\n"
 "Last-Translator: Alan Mortensen <[email protected]>\n"
 "Language-Team: \n"
@@ -18,55 +18,51 @@ msgstr ""
 "Plural-Forms: nplurals=2; plural=(n != 1);\n"
 "X-Generator: Poedit 3.0.1\n"
 
-#. desklet.js:321
+#. desklet.js:79
+msgid "No quotes data to display"
+msgstr ""
+
+#. desklet.js:399
 msgid "Empty quotes list. Open settings and add some symbols."
 msgstr ""
 
-#. desklet.js:343 desklet.js:362
+#. desklet.js:421 desklet.js:440
 msgid "Yahoo Finance service not available!\\nStatus: "
 msgstr "Yahoo Finance er ikke tilgængelig!\\nStatus: "
 
-#. desklet.js:767
+#. desklet.js:795
 msgid "Updated at "
 msgstr "Opdateret "
 
-#. desklet.js:788
+#. desklet.js:828
 msgid "Error: "
 msgstr "Fejl: "
 
-#. desklet.js:892
+#. desklet.js:925
 msgid ""
 "Failed to retrieve authorization parameter! Unable to fetch quotes data."
 "\\nStatus: "
 msgstr ""
 "Kunne ikke hente godkendelsesparameter! Kunne ikke hente kursdata.\n"
 "Status: "
 
-#. desklet.js:917
+#. desklet.js:950
 msgid "Consent processing failed! Unable to fetch quotes data.\\nStatus: "
 msgstr "Samtykkebehandling mislykkedes! Kunne ikke hente kursdata.\\nStatus: "
 
-#. desklet.js:922
+#. desklet.js:955
 msgid ""
 "Consent processing not completed! Unable to fetch quotes data.\\nStatus: "
 msgstr ""
 "Samtykkebehandling ikke gennemført! Kunne ikke hente kursdata.\\nStatus: "
 
-#. desklet.js:944
+#. desklet.js:977
 msgid ""
 "Failed to retrieve authorization crumb! Unable to fetch quotes data."
 "\\nStatus: "
 msgstr ""
 "Kunne ikke hente godkendelseskrumme! Kunne ikke hente kursdata.\\nStatus: "
 
-#. desklet.js:983
-msgid "Cannot display quotes information for symbols: "
-msgstr "Kan ikke vise kurser for symbolerne: "
-
-#. desklet.js:984
-msgid "The following error occurred: "
-msgstr "Følgende fejl opstod: "
-
 #. metadata.json->description
 msgid ""
 "Displays financial market information such as stock quotes and commodity "

diff --git a/files/yfquotes@thegli/po/de.po b/files/yfquotes@thegli/po/de.po
@@ -7,7 +7,7 @@ msgstr ""
 "Project-Id-Version: \n"
 "Report-Msgid-Bugs-To: https://github.com/linuxmint/cinnamon-spices-desklets/"
 "issues\n"
-"POT-Creation-Date: 2024-08-21 22:58+0200\n"
+"POT-Creation-Date: 2024-08-25 22:42+0200\n"
 "PO-Revision-Date: 2023-08-28 16:36+0200\n"
 "Last-Translator: \n"
 "Language-Team: \n"
@@ -17,60 +17,56 @@ msgstr ""
 "Content-Transfer-Encoding: 8bit\n"
 "X-Generator: Poedit 2.3\n"
 
-#. desklet.js:321
+#. desklet.js:79
+msgid "No quotes data to display"
+msgstr "Keine Finanzdaten vorhanden"
+
+#. desklet.js:399
 msgid "Empty quotes list. Open settings and add some symbols."
 msgstr ""
 "Liste der Symbole ist leer. Öffne die Einstellungen und füge Symbole hinzu."
 
-#. desklet.js:343 desklet.js:362
+#. desklet.js:421 desklet.js:440
 msgid "Yahoo Finance service not available!\\nStatus: "
 msgstr "Yahoo Finance Service nicht verfügbar!\\nStatus: "
 
-#. desklet.js:767
+#. desklet.js:795
 msgid "Updated at "
 msgstr "Aktualisiert um "
 
-#. desklet.js:788
+#. desklet.js:828
 msgid "Error: "
 msgstr "Fehler: "
 
-#. desklet.js:892
+#. desklet.js:925
 msgid ""
 "Failed to retrieve authorization parameter! Unable to fetch quotes data."
 "\\nStatus: "
 msgstr ""
 "Empfang von Autorisierungsparameter ist fehlgeschlagen! Finanzdaten-Abfrage "
 "nicht möglich.\\nStatus: "
 
-#. desklet.js:917
+#. desklet.js:950
 msgid "Consent processing failed! Unable to fetch quotes data.\\nStatus: "
 msgstr ""
 "Consent-Erteilung ist fehlgeschlagen! Finanzdaten-Abfrage nicht möglich."
 "\\nStatus: "
 
-#. desklet.js:922
+#. desklet.js:955
 msgid ""
 "Consent processing not completed! Unable to fetch quotes data.\\nStatus: "
 msgstr ""
 "Consent-Erteilung nicht abgeschlossen! Finanzdaten-Abfrage nicht möglich."
 "\\nStatus: "
 
-#. desklet.js:944
+#. desklet.js:977
 msgid ""
 "Failed to retrieve authorization crumb! Unable to fetch quotes data."
 "\\nStatus: "
 msgstr ""
 "Emfang von Autorisierungs-Crumb ist fehlgeschlagen! Finanzdaten-Abfrage "
 "nicht möglich.\\nStatus: "
 
-#. desklet.js:983
-msgid "Cannot display quotes information for symbols: "
-msgstr "Finanzdaten können nicht angezeigt werden für die Symbole: "
-
-#. desklet.js:984
-msgid "The following error occurred: "
-msgstr "Folgender Fehler ist aufgetreten: "
-
 #. metadata.json->description
 msgid ""
 "Displays financial market information such as stock quotes and commodity "

diff --git a/files/yfquotes@thegli/po/es.po b/files/yfquotes@thegli/po/es.po
@@ -7,7 +7,7 @@ msgstr ""
 "Project-Id-Version: \n"
 "Report-Msgid-Bugs-To: https://github.com/linuxmint/cinnamon-spices-desklets/"
 "issues\n"
-"POT-Creation-Date: 2024-08-21 22:58+0200\n"
+"POT-Creation-Date: 2024-08-25 22:42+0200\n"
 "PO-Revision-Date: 2024-08-22 15:09-0400\n"
 "Last-Translator: \n"
 "Language-Team: \n"
@@ -17,60 +17,56 @@ msgstr ""
 "Content-Transfer-Encoding: 8bit\n"
 "X-Generator: Poedit 3.4.4\n"
 
-#. desklet.js:321
+#. desklet.js:79
+msgid "No quotes data to display"
+msgstr ""
+
+#. desklet.js:399
 msgid "Empty quotes list. Open settings and add some symbols."
 msgstr ""
 "Lista de cotizaciones vacía. Abra la configuración y añada algunos símbolos."
 
-#. desklet.js:343 desklet.js:362
+#. desklet.js:421 desklet.js:440
 msgid "Yahoo Finance service not available!\\nStatus: "
 msgstr "El servicio de Yahoo Finanzas no está disponible: "
 
-#. desklet.js:767
+#. desklet.js:795
 msgid "Updated at "
 msgstr "Actualizado en "
 
-#. desklet.js:788
+#. desklet.js:828
 msgid "Error: "
 msgstr "Error: "
 
-#. desklet.js:892
+#. desklet.js:925
 msgid ""
 "Failed to retrieve authorization parameter! Unable to fetch quotes data."
 "\\nStatus: "
 msgstr ""
 "Error al recuperar el parámetro de autorización. No se han podido recuperar "
 "los datos de las cotizaciones: "
 
-#. desklet.js:917
+#. desklet.js:950
 msgid "Consent processing failed! Unable to fetch quotes data.\\nStatus: "
 msgstr ""
 "No se ha podido procesar el consentimiento. No se han podido recuperar los "
 "datos de las cotizaciones: "
 
-#. desklet.js:922
+#. desklet.js:955
 msgid ""
 "Consent processing not completed! Unable to fetch quotes data.\\nStatus: "
 msgstr ""
 "No se ha completado el procesamiento del consentimiento. No se han podido "
 "recuperar los datos de las cotizaciones: "
 
-#. desklet.js:944
+#. desklet.js:977
 msgid ""
 "Failed to retrieve authorization crumb! Unable to fetch quotes data."
 "\\nStatus: "
 msgstr ""
 "¡No se pudo recuperar la ruta de autorización! No se pueden recuperar los "
 "datos de las cotizaciones: "
 
-#. desklet.js:983
-msgid "Cannot display quotes information for symbols: "
-msgstr "No se puede mostrar información de cotizaciones para los símbolos: "
-
-#. desklet.js:984
-msgid "The following error occurred: "
-msgstr "El siguiente error ha ocurrido: "
-
 #. metadata.json->description
 msgid ""
 "Displays financial market information such as stock quotes and commodity "