Don't use obal to git branch & commit + unify bump packages #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
force-pushed
the
unify-packaging
branch
from
ae2e64f
to
8b2821f
Compare
|
I used this (together with #207) for foreman-3.8.0-rc1: theforeman/foreman-packaging#9766 & theforeman/foreman-packaging#9767. And looks like that failed on RPM, so moving back to draft. |
This correctly handles spaces, even though package names should never have spaces.
Obal uses a complex branch name and an obscure commit message. This simplifies the whole workflow and brings it more in line with the Debian side.
ekohl
force-pushed
the
unify-packaging
branch
from
8b2821f
to
6aa5d7b
Compare
|
Now updated and I tested it with RPMs where it previously didn't add the files that obal changed. |
evgeni
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obal uses a complex branch name and an obscure commit message. This simplifies the whole workflow and brings it more in line with the Debian side. After bringing those closer together, the next script introduces a common
bump_packagingscript. The old scripts remain as very light wrappers. The last commit is only there to make shellcheck happy. In practice it wouldn't have been any problem since package names never have spaces, but it's still a good practice.