Add a rel_eng_script macro in procedures #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
approved these changes
Aug 23, 2023
|
You want to merge this as-is, or apply the change to all procedures? |
This makes it easier to link to theforeman-rel-eng scripts.
These scripts were already used in Foreman procedures.
ekohl
force-pushed
the
rel_eng_script-tag
branch
from
1583f3c
to
ec163a4
Compare
I at least did Foreman & Katello. I don't see the Pulp procedures posted so I didn't touch those. Also took the chance to use more scripts that already existed (see last commit). |
evgeni
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to link to theforeman-rel-eng scripts.
Right now this only applied to a single procedure, but it gives a good impression of the changes.