-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change "OS" to "operating system" per RHSSG #3387
base: master
Are you sure you want to change the base?
Conversation
/label need-tech-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Maxim, welcome again to Foreman docs. Diff LGTM minus two file names. In foreman-documentation, we always ensure that the anchor, title, and file name match (minus "proc_" etc prefixes)
@@ -1,5 +1,5 @@ | |||
[id="Determining_Hardware_and_OS_Configuration_{context}"] | |||
= Determining hardware and OS configuration | |||
[id="Determining_Hardware_and_operating_system_Configuration_{context}"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff LGTM, please also rename the file to ensure that file name, anchor, and title matches.
@@ -1,4 +1,4 @@ | |||
[id="Restricting_a_{customrepoid}_to_a_Specific_OS_Version_or_Architecture_in_Project_{context}"] | |||
[id="Restricting_a_{customrepoid}_to_a_Specific_operating_system_Version_or_Architecture_in_Project_{context}"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above.
What changes are you introducing?
Substituting all occurences of "OS" for "operating system".
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
https://issues.redhat.com/browse/SAT-23961
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
--
Checklists
Please cherry-pick my commits into: