Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change "OS" to "operating system" per RHSSG #3387

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change "OS" to "operating system" per RHSSG #3387

wants to merge 1 commit into from

Conversation

rh-max
Copy link

@rh-max rh-max commented Oct 22, 2024

What changes are you introducing?

Substituting all occurences of "OS" for "operating system".

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

https://issues.redhat.com/browse/SAT-23961

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

--

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.12/Katello 4.14 (Satellite 6.16)
  • Foreman 3.11/Katello 4.13
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • Foreman 3.6/Katello 4.8
  • Foreman 3.5/Katello 4.7 (Satellite 6.13; orcharhino 6.6/6.7)
  • We do not accept PRs for Foreman older than 3.5.

@github-actions GitHub Actions
Copy link

The PR preview for 49b32a4 is available at theforeman-foreman-documentation-preview-pr-3387.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

@rh-max
Copy link
Author

rh-max commented Oct 22, 2024

/label need-tech-review
/label need-style-review

maximiliankolb
maximiliankolb requested changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Maxim, welcome again to Foreman docs. Diff LGTM minus two file names. In foreman-documentation, we always ensure that the anchor, title, and file name match (minus "proc_" etc prefixes)

guides/common/modules/proc_determining-hardware-and-os-configuration.adoc
@@ -1,5 +1,5 @@
[id="Determining_Hardware_and_OS_Configuration_{context}"]
= Determining hardware and OS configuration
[id="Determining_Hardware_and_operating_system_Configuration_{context}"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM, please also rename the file to ensure that file name, anchor, and title matches.

...dules/proc_restricting-customrepoid-to-a-specific-os-version-or-architecture-in-project.adoc
@@ -1,4 +1,4 @@
[id="Restricting_a_{customrepoid}_to_a_Specific_OS_Version_or_Architecture_in_Project_{context}"]
[id="Restricting_a_{customrepoid}_to_a_Specific_operating_system_Version_or_Architecture_in_Project_{context}"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above.

@pr-processor pr-processor bot added Waiting on contributor Requires an action from the author and removed Not yet reviewed labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximiliankolb maximiliankolb maximiliankolb requested changes

Assignees
No one assigned
Labels
Waiting on contributor Requires an action from the author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rh-max @maximiliankolb @max-svistunov