Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up external links in procedure to manage hosts using Cockpit #3382

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

asteflova
Copy link
Contributor

What changes are you introducing?

  • Dropping links to Cockpit docs from the list of prerequisites in Managing hosts using Cockpit
  • Grouping the remaining external links under Additional resources in order to make them easier to scan

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

https://issues.redhat.com/browse/SAT-28721 reported that a link to RHEL 9 was missing from the Prerequisites. @adamruzicka suggested to drop the links rather than update the list.

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

N/A

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.12/Katello 4.14 (Satellite 6.16)
  • Foreman 3.11/Katello 4.13
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • Foreman 3.6/Katello 4.8
  • Foreman 3.5/Katello 4.7 (Satellite 6.13; orcharhino 6.6/6.7)
  • We do not accept PRs for Foreman older than 3.5.

Copy link

github-actions bot commented Oct 18, 2024

@asteflova asteflova added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective labels Oct 18, 2024
@asteflova
Copy link
Contributor Author

@adamruzicka Can you please take a look to make sure the rest of the section looks okay?

@Lennonka Lennonka added the Waiting on contributor Requires an action from the author label Oct 23, 2024
We don't want users to think that they need to do any of the
installation etc. steps described in the linked docs
@pr-processor pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author Needs re-review labels Oct 24, 2024
Comment on lines 10 to 16
[NOTE]
====
You can use a job template to install {the-Cockpit}.
To view the template in {ProjectWebUI}, navigate to *Monitor* > *Jobs* and click *Run Job*.
From the *Job category* list, select *Ansible Services*.
From the *Job template* list, select *Service Action {endash} Enable Web Console*.
====
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be too much for a prerequisite but then again, I can't think of a better way to point users to the template. Does anyone have suggestions?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose to move these steps to a procedure to which we can link.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not trying to describe a procedure, just the place where users can find the template. Do you have an alternative solution? What I'm trying to do is let users know that this template exists. I can't think of a way to do that without guiding them through the web UI.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The procedure itself would be 13. Configuring and setting up remote jobs. But how to best point to the particular template to use?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this as a new 9.2 "Enabling Cockput on hosts": https://docs.theforeman.org/nightly/Managing_Hosts/index-katello.html#host-management-and-monitoring-by-using-cockpit or similar.

The procedure itself does not need to duplicate all steps for REX jobs, but reference a procedure and mention the correct job category+job template.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, I'd still like to avoid adding a whole new procedure. I wouldn't want to set a precedent for creating a whole new module every time I'd like to reference a job template/ansible module/etc. I still hope there is a simpler way to achieve that, one that doesn't eventually contribute to doc bloat :)

How about now? Just a note that the template is there and which category it's included in?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I like this much better.

Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor optional suggestions. Overall LGTM

** For {RHEL}{nbsp}8, see {RHELDocsBaseURL}8/html/managing_systems_using_the_rhel_8_web_console/getting-started-with-the-rhel-8-web-console_system-management-using-the-rhel-8-web-console#installing-the-web-console_getting-started-with-the-rhel-8-web-console[Installing the web console] in _Managing systems using the RHEL{nbsp}8 web console_.
** For {RHEL}{nbsp}7, see {RHELDocsBaseURL}7/html/managing_systems_using_the_rhel_7_web_console/getting-started-with-the-rhel-web-console_system-management-using-the-rhel-7-web-console#installing-the-web-console_getting-started-with-the-web-console[Installing the web console] in _Managing systems using the RHEL{nbsp}7 web console_.
endif::[]
* You have installed {the-Cockpit} on the host that you want to view.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* You have installed {the-Cockpit} on the host that you want to view.
* You have installed {the-Cockpit} on the host that you want to manage and monitor.

"view" is probably not doing Web Console any justice. I've copied the verbs from the heading. Does this make sense? Or maybe just "manage"? Or "interact with"?

* You have installed {the-Cockpit} on the host that you want to view.
+
{Project} provides a job template named *Service Action {endash} Enable Web Console* under the *Ansible Services* job category that you can use to install {the-Cockpit}.
For more information about using remote jobs, see xref:Configuring_and_Setting_Up_Remote_Jobs_{context}[].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For more information about using remote jobs, see xref:Configuring_and_Setting_Up_Remote_Jobs_{context}[].
For more information about running remote jobs, see xref:Configuring_and_Setting_Up_Remote_Jobs_{context}[].

Or "execute" like https://docs.theforeman.org/nightly/Managing_Hosts/index-katello.html#executing-a-remote-job_managing-hosts?

@maximiliankolb maximiliankolb added style review done No issues from docs style/grammar perspective and removed Needs style review Requires a review from docs style/grammar perspective labels Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs tech review Requires a review from the technical perspective style review done No issues from docs style/grammar perspective
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants