-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention that the external database should be upgraded #3374
base: master
Are you sure you want to change the base?
Mention that the external database should be upgraded #3374
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be better as a second prerequisite?
Something like "Install PostgreSQL version 13 on the new RHEL host"?
d0b3bd9
to
8db9cdb
Compare
@Lennonka agreed. Makes sense to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I've set both "review done" labels because it's correct that PG 13 is needed for 3.12/6.16 and I have reviewed the style as well. |
I don't think it's a good idea to set @AkshayGadhaveRH please work with the Platform team to secure a proper technical review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What we need to tell our users (but do not today) is that they have to upgrade PostgreSQL from 12 to 13 on their external DB server during the upgrade to 6.16/3.12(3.11).
We have the "On {EL} 8: Switch to the PostgreSQL 13 module" step -- either before of after that we should say something like "If you're running an external database setup, upgrade the external database to PostgreSQL 13".
@evgeni does this plan look good? (also, small question for you)
|
|
8db9cdb
to
26ee8fb
Compare
guides/common/modules/proc_upgrading-a-connected-project-server.adoc
Outdated
Show resolved
Hide resolved
ifdef::satellite[] | ||
. If you are using an external database, upgrade to PostgreSQL 13. | ||
endif::[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to happen before satellite-maintain upgrade check
, as that one will already complain about the wrong version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have to mention this step twice in one procedure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I just move this to the end for both Foreman and Satellite @evgeni ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Twice in the same procedure? No.
But Foreman/Katello and Satellite procedures are quite different, and each of them needs that step.
guides/common/modules/proc_upgrading-a-connected-project-server.adoc
Outdated
Show resolved
Hide resolved
ifdef::satellite[] | ||
. If you are using an external database, upgrade to PostgreSQL 13. | ||
endif::[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have to mention this step twice in one procedure?
Looks good to me. @evgeni Do we have a technical ack? |
guides/common/modules/proc_upgrading-a-connected-project-server.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_upgrading-a-connected-project-server.adoc
Outdated
Show resolved
Hide resolved
The external database should be upgraded from PostgreSQL 12 to 13. Mentioning this in the ext DB upgrade chapter. JIRA: https://issues.redhat.com/browse/SAT-28273
- Changed external DB upgrade chapter to talk about EL8 to 9 upgrade. - Mentioned that external DB needs to be upgraded to PostgreSQL 13 in the switch to pgsql 13 module step. - Replaced PostgreSQL 12 with PostgreSQL 13 in the `Setting up external DB` doc.
- Move PostgreSQL related steps to the end. - Unify steps for all builds so that there's no need to repeat the steps. - Add changes for disconnected upgrade guide as well.
1bf07a2
to
cc726f1
Compare
The external database should be upgraded from PostgreSQL 12 to 13. Mentioning this in the ext DB upgrade chapter.
JIRA: https://issues.redhat.com/browse/SAT-28273
What changes are you introducing?
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Checklists
Please cherry-pick my commits into: