Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Improvement - Add method annotations in iterator generated classes #242

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dsavina
Copy link
Contributor

@dsavina dsavina commented Dec 31, 2020

Add type hint for methods first, toArray, offsetGet, withOrder, withParameters in base iterator classes.

@codecov-io
Copy link

codecov-io commented Dec 31, 2020

Codecov Report

Merging #242 (01c0eb8) into master (a49d62d) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #242      +/-   ##
============================================
- Coverage     97.54%   97.45%   -0.10%     
- Complexity     1482     1483       +1     
============================================
  Files            62       62              
  Lines          4159     4168       +9     
============================================
+ Hits           4057     4062       +5     
- Misses          102      106       +4     
Impacted Files Coverage Δ Complexity Δ
src/Utils/BeanDescriptor.php 98.54% <100.00%> (+0.01%) 191.00 <0.00> (+1.00)
src/QueryFactory/FindObjectsQueryFactory.php 97.61% <0.00%> (-2.39%) 9.00% <0.00%> (ø%)
src/TDBMService.php 96.43% <0.00%> (-0.60%) 180.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a49d62d...01c0eb8. Read the comment docs.

@dsavina dsavina changed the title Improvement - Add method annotations in iterator generated classes Draft: Improvement - Add method annotations in iterator generated classes Jan 5, 2021
@dsavina dsavina marked this pull request as draft January 5, 2021 09:33
@moufmouf
Copy link
Member

moufmouf commented Jan 6, 2021

We could try to use generics from PHPStan / Psalm instead. Especially since PHPStorm reads those annotations since the last version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants