Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/deeper composite fk #230

Merged
merged 4 commits into from
Sep 30, 2020
Merged

Fix/deeper composite fk #230

merged 4 commits into from
Sep 30, 2020

Conversation

homersimpsons
Copy link
Collaborator

Fixes #207

This fixes a corner case in serialization code about a schema looking like:

  summary_tdh  |  summary     |  entity
  entity_id   <=> entity_id  <=> entity_id
  summary_id  <=> summary_id

Where <=> reflects a Foreign Key

@coveralls
Copy link

coveralls commented Sep 24, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.006%) to 97.187% when pulling 9d060fc on homersimpsons:fix/deeper_composite_fk into a20710b on thecodingmachine:5.1.

@moufmouf
Copy link
Member

There seems to be a PHPStan issue to solve and this should be all right!

@moufmouf
Copy link
Member

👍

@moufmouf moufmouf merged commit 5a7bb2e into thecodingmachine:5.1 Sep 30, 2020
@moufmouf
Copy link
Member

@homersimpsons Can you backport this to the master branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moufmouf moufmouf Awaiting requested review from moufmouf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@homersimpsons @coveralls @moufmouf