Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Sendable conformances @unchecked in addition to @retroactive #166

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Make Sendable conformances @unchecked in addition to @retroactive #166

merged 1 commit into from
Apr 19, 2024

Conversation

tristanlabelle
Copy link
Contributor

@tristanlabelle tristanlabelle commented Apr 19, 2024 •
edited
Loading

Otherwise this results in a bunch of warnings:

..\Windows.Foundation.swift:731:1: warning: conformance to 'Sendable' must occur in the same source file as struct '__x_ABI_CWindows_CFoundation_CAsyncStatus'; use '@unchecked Sendable' for retroactive conformance; this is an error in the Swift 6 language mode

@tristanlabelle tristanlabelle requested a review from a team as a code owner April 19, 2024 19:09
@tristanlabelle tristanlabelle merged commit ce11bb3 into main Apr 19, 2024
1 check passed
@tristanlabelle tristanlabelle deleted the tristan/sendable-unchecked branch April 19, 2024 19:15
kendalharland pushed a commit that referenced this pull request Jun 11, 2024
@tristanlabelle
Make Sendable conformances @unchecked in addition to @retroactive (#166)
4c90c66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jumhyn-browser jumhyn-browser jumhyn-browser approved these changes

@mliberman mliberman mliberman approved these changes

@jeffdav jeffdav Awaiting requested review from jeffdav

@stevenbrix stevenbrix Awaiting requested review from stevenbrix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tristanlabelle @mliberman @jumhyn-browser