Remove an extra string copy while constructing HString #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristanlabelle
approved these changes
Apr 9, 2024
compnerd
reviewed
Apr 9, 2024
vinocher-bc
force-pushed
the
vinoo/HStringPreallocate2
branch
from
444d232 to
36bcdd3
Compare
compnerd
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an
HStringis currently constructed, thewithCStringmethod makes a copy of the source string for null termination. ThenWindowsCreateStringcreated a second copy. AnHSTRINGdoesn't need a null terminated string for construction, so removewithCStringand use a single allocation byWindowsPreallocateStringBuffer.The contents of the source string are copied into the
HSTRING_BUFFERcreated byWindowsPreallocateStringBuffer, and anHSTRINGis created from that buffer usingWindowsPromoteStringBuffer.Fixes DEVIN-1237