Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set compilers in presets #151

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Set compilers in presets #151

merged 3 commits into from
Mar 29, 2024

Conversation

tristanlabelle
Copy link
Contributor

@tristanlabelle tristanlabelle commented Mar 29, 2024

After the github runner update, we fail to build with our late-set compilers. The CI build with clang-cl was also causing errors in standard library headers. Since we don't need to debug the CI build, we can build it using cl.

@tristanlabelle tristanlabelle marked this pull request as ready for review March 29, 2024 19:39
@tristanlabelle tristanlabelle requested a review from a team as a code owner March 29, 2024 19:39
Copy link
Contributor

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

@tristanlabelle tristanlabelle merged commit 2108d3f into main Mar 29, 2024
1 check passed
@tristanlabelle tristanlabelle deleted the tristan/compilers-in-presets branch March 29, 2024 19:43
stevenbrix added a commit that referenced this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants