Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fixes were required to get the
Microsoft.Graphics.Canvas
WinMD to build, the few things that this winmd uncovered:subscript
is a method and needs to be escaped with backticksclass
methods and the derived types have to sayoverride
Changes
w.add_depends
in some places where we don't use any of thewrite(type)
methods. We don't use those methods because swift name requirements for deriving from a generic interface don't follow "normal" (as in what most other languages do - where you needIFoo
instead ofIFoo<Bar>
) naming patterns. Plus those write methods are fragile so just adding theadd_depends
instead of modifying the write methods to do the right thingsubscript
to the list of names that need backticksbase_has_matching_constructor
and a match is considered if the following are true:a. function name matches
b. parameters match
c. return type of derived static method is the same or derived from the return of the base class
Testing
Added test cases