Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve the crashpad_handler IPC endpoint from sentry-native #40

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

sgraham
Copy link
Contributor

@sgraham sgraham commented Apr 29, 2024

After crashpad_handler has started, grab the endpoint of the pipe server that crashpad_handler is running, and stash it in an environment variable.

This method, and the name of envvar matches Chromium https://source.chromium.org/search?q=CHROME_CRASHPAD%20case:yes&sq=&ss=chromium which will allow the child process registration to work in the same way, and let the environment variable through the sandbox to child processes which otherwise have no environment.

Added to sentry-native here: thebrowsercompany/sentry-native#10.

Testing: manual via System Informer
image

@sgraham sgraham requested a review from sebmarchand April 30, 2024 00:23
@sgraham sgraham merged commit 2b0e623 into main Apr 30, 2024
@sgraham sgraham deleted the get-handler-pipe-name branch May 7, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants