Add ability to do recursive loading #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting, thank you for doing this! I'm out of office for a bit but I'll take a closer look next week. :) |
|
This mostly looks good, but it looks like there's a lint failure. Could you get that addressed? |
|
Yes, I believe that should do it. |
|
Just got the pipeline message, didn't realize there were multiple linters, I'll check more thoroughly. |
|
Looks like prettier is still unhappy. If you don't wanna fight with it just lmk and I can handle getting it mergeable from here. |
|
Yep format was only thing needed, should be okay now |
|
Rad, thank you for doing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will automatically load any identifiable schematic file recursively. It supports a custom resolver for kicanvas-embed webcomponent which allows the user to specify where to find other files.
A working example exists at https://git.devdroplets.com/Ryan/violent-scripts/-/blob/master/scripts/kicanvas-gitlab/kicanvas-gitlab.ts ; a user-script which adds KiCanvas to gitlabs file preview page
(this should resolve #77 at least partially)