Add support for SplitKB Kyria rev.3 board #2071
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l-lang
changed the title
Xelus22
requested changes
Nov 5, 2023
Comment on lines
+5
to
+7
| "keycodes": [ | ||
| "qmk_lighting" | ||
| ], |
There was a problem hiding this comment.
Specified rgb keycodes but not the accompanying menus?
Also see the RGB matrix stuff https://github.com/qmk/qmk_firmware/blob/master/keyboards/splitkb/kyria/rev3/info.json#L125
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The SplitKB Kyria rev3 has a different key matrix and a different productId than previous revisions.
QMK Pull Request
VIA support for Kyria has been in QMK master for quite some time now:
qmk/qmk_firmware#19676
Checklist
0xFEED