Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework par. 5 of introduction #353

Merged
merged 1 commit into from
Aug 10, 2024
Merged

Rework par. 5 of introduction #353

merged 1 commit into from
Aug 10, 2024

Conversation

jpthiele
Copy link
Collaborator

First draft for addressing the first checkbox of #341

@jpthiele jpthiele mentioned this pull request Aug 10, 2024
Open
@jpthiele jpthiele force-pushed the jpt-introduction-technical branch from 4913b67 to 609b236 Compare August 10, 2024 08:11
@jpthiele jpthiele requested a review from jcohen02 August 10, 2024 08:25
mhagdorn
mhagdorn approved these changes Aug 10, 2024
View reviewed changes
Copy link
Collaborator

@mhagdorn mhagdorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this reads better now and makes it clearer what we are trying to say.

@CaptainSifff CaptainSifff self-requested a review August 10, 2024 12:33
@CaptainSifff CaptainSifff merged commit 08b589a into main Aug 10, 2024
5 checks passed
jcohen02
jcohen02 reviewed Aug 10, 2024
View reviewed changes
Copy link
Collaborator

@jcohen02 jcohen02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this has already been merged but a +1 from me too - thanks for doing this @jpthiele.

@jpthiele jpthiele deleted the jpt-introduction-technical branch August 12, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcohen02 jcohen02 jcohen02 left review comments

@CaptainSifff CaptainSifff CaptainSifff approved these changes

@mhagdorn mhagdorn mhagdorn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jpthiele @mhagdorn @CaptainSifff @jcohen02