my testing of fixes to fix the mobile issue #68
Merged
+21
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dit buttons for styling, list item classes for responsiveness
|
Visit the preview URL for this PR (updated for commit 7bd9fea): https://tcl-77-smart-shopping-list--pr68-bb-fix-responsive-fr-diwtnt5f.web.app (expires Fri, 25 Oct 2024 22:06:08 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b77df24030dca7d8b6561cb24957d2273c5e9d72 |
|
Quick screen recording of the preview link with the changes. We could probably remove the the |
eternalmaha
reviewed
Oct 18, 2024
| @@ -142,14 +141,14 @@ export function ListItemCheckBox({ item, listPath }: Props) { | |||
| aria-checked={isChecked} | |||
| disabled={isChecked} | |||
| /> | |||
| <h4 className="text-nowrap me-1 mb-0"> {item.name} </h4> | |||
| <Form.Label className="">{item.name}</Form.Label> | |||
There was a problem hiding this comment.
When I tested it, the larger text size pushes some content out. I'll use a responsive font size when I do merge!
item-text.mov
.item-text {
font-size: 0.75em;
}
}
eternalmaha
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I branched off of @eternalmaha list page view and did some adjustments to see if I could help find a fix. This is what I came up with. Wanted to make the branch, and push a PR to go to her branch for easier checking and reviewing.