Fix sample stats for step invariant and subquery #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harry671003
force-pushed
the
fuzz_query_stats
branch
from
924e9c4 to
d122688
Compare
fpetkovski
reviewed
Jan 5, 2025
yeya24
reviewed
Jan 5, 2025
harry671003
force-pushed
the
fuzz_query_stats
branch
2 times, most recently
from
c40ab9b to
f86337d
Compare
harry671003
changed the title
harry671003
force-pushed
the
fuzz_query_stats
branch
2 times, most recently
from
ff6d901 to
7263b8d
Compare
fpetkovski
reviewed
Jan 6, 2025
engine/explain.go
Outdated
| if a.OperatorTelemetry.StepInvariant() { | ||
| // Children of step invariant operator outputs one step, but they should be counted towards all the steps. | ||
| for i := 0; i < len(a.totalSamplesPerStep); i++ { | ||
| childSamples := child.TotalSamples() |
There was a problem hiding this comment.
Do we need to recalculate this for each loop iteration?
I also wonder if we can modify the implementation of the step invariant analysis to fit into the existing algorithm instead of tweaking the algorithm to specially handle the step invariant case.
There was a problem hiding this comment.
I also wonder if we can modify the implementation of the step invariant analysis
The other option was to IncrementSamples() in StepInvariant operator and skip counting samples from its children. I initially preferred this option, but ran into problem with pi(). The stepInvariant operator doesn't know if these samples are real samples or synthetic samples.
harry671003
force-pushed
the
fuzz_query_stats
branch
from
7263b8d to
0145afa
Compare
Signed-off-by: 🌲 Harry 🌊 John 🏔 <[email protected]>
harry671003
force-pushed
the
fuzz_query_stats
branch
2 times, most recently
from
1d2c3de to
1f7de1f
Compare
Signed-off-by: 🌲 Harry 🌊 John 🏔 <[email protected]>
harry671003
force-pushed
the
fuzz_query_stats
branch
from
1f7de1f to
d89d82a
Compare
Signed-off-by: 🌲 Harry 🌊 John 🏔 <[email protected]>
fpetkovski
approved these changes
Jan 10, 2025
yeya24
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Note
Fuzzing did uncover a case which cannot be addressed without an upstream change