engine: allow to override opts at query time #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaHoffmann
force-pushed
the
mhoffmann/allow-to-override-engine-opts-at-query-time
branch
from
fc6c3fe to
52d860e
Compare
MichaHoffmann
commented
Dec 15, 2024
| res.LookbackDelta = opts.LookbackDelta() | ||
| } | ||
| if opts.EnablePerStepStats() { | ||
| res.EnablePerStepStats = opts.EnablePerStepStats() |
There was a problem hiding this comment.
This maybe should be &= but im not sure if original logic was a bug or not!
Signed-off-by: Michael Hoffmann <[email protected]>
MichaHoffmann
force-pushed
the
mhoffmann/allow-to-override-engine-opts-at-query-time
branch
from
52d860e to
fc40cf4
Compare
|
Maybe we should first create our own interface, and an adapter for the Prometheus engine. It looks like we are struggling to add features because we are coupled to the Prometheus interface. |
pedro-stanaka
approved these changes
Dec 16, 2024
Will do |
Signed-off-by: Michael Hoffmann <[email protected]>
MichaHoffmann
force-pushed
the
mhoffmann/allow-to-override-engine-opts-at-query-time
branch
from
c6b4621 to
50340b9
Compare
fpetkovski
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to override engine settings at query time by providing a custom QueryOption struct that implements the promql.QueryOpts interface and can be provided at runtime.
This prepares eventually overriding more options through this to allow controlling more behavior at query time ( i.e. optimizers, fallback; etc).