Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix build.linux.desktop.entry #2859

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

h-banii
Copy link
Contributor

@h-banii h-banii commented Jan 11, 2025

This fixes the build.linux.desktop.entry in the package.json

According to electron-builder's documentation, the entry should be an object describing the desktop entry
https://www.electron.build/app-builder-lib.interface.linuxdesktopfile#entry

Since commit 8de2735, the entry is being set to a string, so the .desktop file generated has bogus key-values.

before this PR
[Desktop Entry]
0=c
1=o
2=m
3=.
4=g
5=i
6=t
7=h
8=u
9=b
10=.
11=t
12=h
13=_
14=c
15=h
16=.
17=y
18=o
19=u
20=t
21=u
22=b
23=e
24=_
25=m
26=u
27=s
28=i
29=c
Name=YouTube Music
Exec=AppRun --no-sandbox %U
Terminal=false
Type=Application
Icon=youtube-music
StartupWMClass=YouTube Music
X-AppImage-Version=3.7.1
Comment=YouTube Music Desktop App bundled with custom plugins (and built-in ad blocker / downloader)
Categories=AudioVideo;
after this PR
[Desktop Entry]
Name=YouTube Music
Exec=AppRun --no-sandbox %U
Terminal=false
Type=Application
Icon=youtube-music
StartupWMClass=com.github.th_ch.youtube_music
X-AppImage-Version=3.7.1
Comment=YouTube Music Desktop App bundled with custom plugins (and built-in ad blocker / downloader)
Categories=AudioVideo;

(.desktop files above were extracted from the AppImages generated)

@JellyBrick
Copy link
Collaborator

Thanks!

@JellyBrick JellyBrick merged commit e37f225 into th-ch:master Jan 11, 2025
6 checks passed
@h-banii h-banii deleted the fix-package-desktop-entry-prop branch January 11, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants