-
-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RecentFiles module #237
base: master
Are you sure you want to change the base?
Conversation
@EchterAgo I don't find an easy way to split up a big branch into small independent ones, so I started to reinvent wheels, Sorry and thanks. All are almost identical to your cleanup branch except two things: (1) in OpenRecentFileCommandHandler:
(2) in PersistedDocument:
For your reference, a merge of 4 PRs is https://github.com/diluculo/gemini/tree/215_Merged. |
Yea, you can't always split up everything into independent units, I have the same problem. In these cases I either waited until the first part was merged and then submitted another pull request, or I included the first commits into the second pull request and rebased upon merge. BTW, I'm in Seoul right now doing a project involving Gemini, so your Korean language support is very appreciated 👍 |
@nestquik Thanks. XML serialization may be better than StringCollection. I made a cleanup of your PR, rebased on master: By the way, your PR shows a couple of |
Thanks. I'm newbie on git, so I can make mistakes. About notifypropertychanged - it should notify on change, doesn't it? I'm trying to build home view module like in VS at this moment. |
ca697e2
to
ac550e2
Compare
#215 is now separated into 4 independent PRs:
This is the first part.