ci: upgrade to Go 1.23

.github/workflows/commit.yaml

@@ -51,7 +51,7 @@ jobs:
             ~/.cache/golangci-lint
             ~/go/pkg/mod
             ~/go/bin
-          key: check-${{ runner.os }}-go-${{ matrix.go-version }}-${{ hashFiles('**/go.sum', 'Makefile') }}
+          key: check-${{ runner.os }}-go-${{ env.GO_VERSION }}-${{ hashFiles('**/go.sum', 'Makefile') }}
 
       - run: make build.spectest
 
@@ -71,9 +71,8 @@ jobs:
         - os: macos-14
           arch: arm64
         go-version:
-          - "1.23.0-rc.2"  # Test the pending next version
-          - "1.22"  # Current Go version
-          - "1.20"  # Floor Go version of wazero (current - 2)
+          - "1.23"  # Current Go version
+          - "1.21"  # Floor Go version of wazero (current - 2)
 
     steps:
 
@@ -113,9 +112,8 @@ jobs:
       fail-fast: false  # don't fail fast as sometimes failures are arch/OS specific
       matrix:  # Use versions consistent with wazero's Go support policy.
         go-version:
-          - "1.23.0-rc.2"  # Test the pending next version
-          - "1.22"  # Current Go version
-          - "1.20"  # Floor Go version of wazero (current - 2)
+          - "1.23"  # Current Go version
+          - "1.21"  # Floor Go version of wazero (current - 2)
         arch:
           - "amd64"
           - "arm64"
@@ -160,7 +158,7 @@ jobs:
     steps:
       - uses: actions/checkout@v2
       - uses: actions/setup-go@v2
-        with:
+        with:  # Use version consistent with TinyGo.
           go-version: "1.22"
       - uses: acifani/setup-tinygo@v2
         with:

.github/workflows/examples.yaml

@@ -35,7 +35,7 @@ jobs:
       matrix:  # Use versions consistent with TinyGo.
         go-version:
           - "1.22"
-          - "1.20"
+          - "1.21"
 
     steps:
       - name: Checkout
@@ -84,7 +84,6 @@ jobs:
 
       - name: Build TinyGo examples
         run: make build.examples.tinygo
-        if: matrix.go-version != '1.20' # fails with TinyGo v0.32.0
 
       - name: Build AssemblyScript examples
         run: make build.examples.as

.github/workflows/integration.yaml

@@ -18,7 +18,7 @@ defaults:
     shell: bash
 
 env:  # Update this prior to requiring a higher minor version in go.mod
-  GO_VERSION: "1.22"
+  GO_VERSION: "1.23"
   TINYGO_VERSION: "0.32.0"
   ZIG_VERSION: "0.11.0"
   BINARYEN_VERSION: "116"
@@ -146,8 +146,8 @@ jobs:
 
       - uses: actions/setup-go@v4
         if: steps.binary-cache.outputs.cache-hit != 'true'
-        with:
-          go-version: ${{ env.GO_VERSION }}
+        with:  # Use version consistent with TinyGo.
+          go-version: "1.22"
 
       - name: Build Test Binaries
         if: steps.binary-cache.outputs.cache-hit != 'true'
@@ -276,9 +276,8 @@ jobs:
           name: Windows
           arch: amd64
         go-version:
+          - "1.23"
           - "1.21"
-          - "1.22"
-          - "1.23.0-rc.2"  # Test the pending next version
 
     steps:
       - id: setup-go

.github/workflows/release.yaml

@@ -11,7 +11,7 @@ on:
     tags: 'v[0-9]+.[0-9]+.[0-9]+**'  # Ex. v0.2.0 v0.2.1-rc2
 
 env: # Update this prior to requiring a higher minor version in go.mod
-  GO_VERSION: "1.22"
+  GO_VERSION: "1.23"
 
 defaults:
   run:  # use bash for all operating systems unless overridden

experimental/wazerotest/wazerotest.go

@@ -379,9 +379,7 @@ func (f *Function) Call(ctx context.Context, params ...uint64) ([]uint64, error)
 	copy(stack, params)
 	err := f.CallWithStack(ctx, stack)
 	if err != nil {
-		for i := range stack {
-			stack[i] = 0
-		}
+		clear(stack)
 	}
 	return stack[:len(f.ResultTypes)], err
 }

go.mod

@@ -1,7 +1,7 @@
 module github.com/tetratelabs/wazero
 
 // Floor Go version of wazero (current - 2)
-go 1.20
+go 1.21
 
 // All the beta tags are retracted and replaced with "pre" to prevent users
 // from accidentally upgrading into the broken beta 1.

imports/wasi_snapshot_preview1/poll.go

@@ -68,9 +68,7 @@ func pollOneoffFn(_ context.Context, mod api.Module, params []uint64) sys.Errno
 	}
 	outBuf, ok := mem.Read(out, nsubscriptions*32)
 	// zero-out all buffer before writing
-	for i := range outBuf {
-		outBuf[i] = 0
-	}
+	clear(outBuf)
 
 	if !ok {
 		return sys.EFAULT

internal/descriptor/table.go

@@ -154,11 +154,6 @@ func (t *Table[Key, Item]) Range(f func(Key, Item) bool) {
 
 // Reset clears the content of the table.
 func (t *Table[Key, Item]) Reset() {
-	for i := range t.masks {
-		t.masks[i] = 0
-	}
-	var zero Item
-	for i := range t.items {
-		t.items[i] = zero
-	}
+	clear(t.masks)
+	clear(t.items)
 }

internal/engine/wazevo/backend/regalloc/regset.go

@@ -55,9 +55,7 @@ func newRegInUseSet[I Instr, B Block[I], F Function[I, B]]() regInUseSet[I, B, F
 }
 
 func (rs *regInUseSet[I, B, F]) reset() {
-	for i := range rs {
-		rs[i] = nil
-	}
+	clear(rs[:])
 }
 
 func (rs *regInUseSet[I, B, F]) format(info *RegisterInfo) string { //nolint:unused

internal/engine/wazevo/frontend/sort_id.go

@@ -1,5 +1,3 @@
-//go:build go1.21
-
 package frontend
 
 import (

internal/engine/wazevo/ssa/basic_block_sort.go

@@ -1,5 +1,3 @@
-//go:build go1.21
-
 package ssa
 
 import (

internal/engine/wazevo/wazevoapi/resetmap.go

@@ -5,9 +5,7 @@ func ResetMap[K comparable, V any](m map[K]V) map[K]V {
 	if m == nil {
 		m = make(map[K]V)
 	} else {
-		for v := range m {
-			delete(m, v)
-		}
+		clear(m)
 	}
 	return m
 }

internal/integration_test/fuzz/go.mod

@@ -1,6 +1,6 @@
 module github.com/tetratelabs/wazero/internal/integration_test/fuzz
 
-go 1.20
+go 1.21
 
 require github.com/tetratelabs/wazero v0.0.0
 

internal/version/testdata/go.mod

@@ -1,6 +1,6 @@
 module github.com/tetratelabs/wazero/internal/version/testdata
 
-go 1.20
+go 1.21
 
 require github.com/tetratelabs/wazero v0.0.0-20220818123113-1948909ec0b1 // indirect
 

internal/wasm/store.go

@@ -3,6 +3,7 @@ package wasm
 import (
 	"context"
 	"encoding/binary"
+	"errors"
 	"fmt"
 	"sync"
 	"sync/atomic"
@@ -659,20 +660,20 @@ func (s *Store) GetFunctionTypeID(t *FunctionType) (FunctionTypeID, error) {
 }
 
 // CloseWithExitCode implements the same method as documented on wazero.Runtime.
-func (s *Store) CloseWithExitCode(ctx context.Context, exitCode uint32) (err error) {
+func (s *Store) CloseWithExitCode(ctx context.Context, exitCode uint32) error {
 	s.mux.Lock()
 	defer s.mux.Unlock()
 	// Close modules in reverse initialization order.
+	var errs []error
 	for m := s.moduleList; m != nil; m = m.next {
 		// If closing this module errs, proceed anyway to close the others.
-		if e := m.closeWithExitCode(ctx, exitCode); e != nil && err == nil {
-			// TODO: use multiple errors handling in Go 1.20.
-			err = e // first error
+		if err := m.closeWithExitCode(ctx, exitCode); err != nil {
+			errs = append(errs, err)
 		}
 	}
 	s.moduleList = nil
 	s.nameToModule = nil
 	s.nameToModuleCap = 0
 	s.typeIDs = nil
-	return
+	return errors.Join(errs...)
 }

sys/stat_unsupported.go

@@ -7,9 +7,6 @@ import "io/fs"
 // sysParseable is only used here as we define "supported" as being able to
 // parse `info.Sys()`. The above `go:build` constraints exclude 32-bit until
 // that's requested.
-//
-// TODO: When Go 1.21 is out, use the "unix" build constraint (as 1.21 makes
-// our floor Go version 1.19.
 const sysParseable = false
 
 func statFromFileInfo(info fs.FileInfo) Stat_t {