Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: adds comments on anonymous module names #2275

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Conversation

mathetake
Copy link
Member

Anonymous modules are introduced like a few years ago
to allow multiple/concurrent instantiations from a single
binary. That was not documented enough well, so this
adds doc comments in the API.

@mathetake mathetake requested a review from anuraaga June 28, 2024 14:28
@ncruces
Copy link
Collaborator

ncruces commented Jun 28, 2024

I'm an “expert” (supposedly) and this tripped me multiple times already.

@mathetake mathetake requested a review from ncruces June 28, 2024 14:37
Signed-off-by: Takeshi Yoneda <[email protected]>
@mathetake mathetake merged commit 26d3aeb into main Jun 28, 2024
45 checks passed
@mathetake mathetake deleted the docanonymousmodule branch June 28, 2024 14:47
@mathetake
Copy link
Member Author

Thanks for the look @ncruces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants