Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasi: manually adds dot and dot-dot directory entries #1152

Merged
merged 2 commits into from
Feb 22, 2023
Merged

wasi: manually adds dot and dot-dot directory entries #1152

merged 2 commits into from
Feb 22, 2023

Commits on Feb 22, 2023

  1. wasi: manually adds dot and dot-dot directory entries 

    This manually adds dot and dot-dot directory entries discarded by
compilers like Go. Doing so complies with the latest interpretation of
wasi preview1 without forcing us to do the same in preview2 or in
GOOS=js. There's a cost penalty of one stat per directory list, which
will be only measurable when using real file I/O.

This should result in us being able to remove the exclusion here
https://github.com/WebAssembly/wasi-testsuite/pull/55/files#diff-8a3ffd323d75a12f8deb01b053f062876d83dda0b89c1fa24b293cee4195bcfd

See WebAssembly/wasi-testsuite#52

Signed-off-by: Adrian Cole <[email protected]>
    Adrian Cole committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    ff7c0e0 View commit details
    Browse the repository at this point in the history

  2. try remove skip 

    Signed-off-by: Adrian Cole <[email protected]>
    Adrian Cole committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    bb3ecf6 View commit details
    Browse the repository at this point in the history